Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples on website does not work with smartcore 0.3.0 #243

Open
1 of 3 tasks
Luosuu opened this issue Nov 17, 2022 · 3 comments
Open
1 of 3 tasks

Examples on website does not work with smartcore 0.3.0 #243

Luosuu opened this issue Nov 17, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@Luosuu
Copy link

Luosuu commented Nov 17, 2022

I'm submitting a

  • bug report.
  • improvement.
  • feature request.

Current Behaviour:

The example provided in the official website does not run properly with the version 0,3,0.

The current document is for version 0.2.0 and the example for SVM:

let y_hat_svm = SVC::fit(&x_train, &y_train, SVCParameters::default().with_c(10.0))
    .and_then(|svm| svm.predict(&x_test))
    .unwrap();

will result in the error:

mismatched types
expected reference `&SVCParameters<f64, u32, DenseMatrix<f64, Vec<u32, Global>>`
found struct `SVCParameter<{float}, _, _, _>` rustc(E0308)

Expected Behaviour:

Error should be removed.

Steps to reproduce:

run the example code directly with smartcore 0.3.0

Snapshot:

Environment:

  • rustc version 1.65.0 (897e37553 2022-11-02)
  • cargo version 1.65.0 (4bc8f24d3 2022-10-20)
  • OS details WSL2 Debian

Do you want to work on this issue?

no

@Mec-iS
Copy link
Collaborator

Mec-iS commented Nov 17, 2022

thanks for reporting this.

Working examples can be found in the notebooks: https://github.com/smartcorelib/smartcore-jupyter/tree/main/notebooks

@Luosuu
Copy link
Author

Luosuu commented Nov 17, 2022

thanks for reporting this.

Working examples can be found in the notebooks: https://github.com/smartcorelib/smartcore-jupyter/tree/main/notebooks

Is there any plan of adding documentation for smartcore 0.3.0 on the website?

@Mec-iS
Copy link
Collaborator

Mec-iS commented Nov 17, 2022

the content of the website is open for revisions at https://github.com/smartcorelib/smartcorelib.org

@Mec-iS Mec-iS added the good first issue Good for newcomers label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants