Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for env vars in playbook #164

Closed
colmsnowplow opened this issue Aug 28, 2020 · 1 comment
Closed

Add support for env vars in playbook #164

colmsnowplow opened this issue Aug 28, 2020 · 1 comment

Comments

@colmsnowplow
Copy link
Contributor

colmsnowplow commented Aug 28, 2020

We added support for env vars here - however it looks like this is evaluated at runtime and can only be used as a template within actual SQL files.

It would be a nice quality of life improvement to be able to set parts of the playbook configuration via env vars too - for example connection details for the database. I'm quite fond of the approach that great_expectations takes to this problem - which allows one to use a separate YAML file for creds, environment variables, or a combination of both.

It brings a much lower risk of leaking credentials.

@colmsnowplow
Copy link
Contributor Author

Looks like I reported this one already then forgot 🤦 #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant