From f83acaaf3d955f89d0b83d1546ca5426f7c57ac4 Mon Sep 17 00:00:00 2001
From: hwmin414 <hwmin414@kiast.ac.kr>
Date: Wed, 13 Mar 2024 01:47:25 +0900
Subject: [PATCH] fix: aws explicitly throw error, change to new interface

---
 src/modules/stores/aws.js | 28 ++++++++++++----------------
 src/services/chats.js     | 16 ++--------------
 2 files changed, 14 insertions(+), 30 deletions(-)

diff --git a/src/modules/stores/aws.js b/src/modules/stores/aws.js
index 7f87b63c..48ccc754 100644
--- a/src/modules/stores/aws.js
+++ b/src/modules/stores/aws.js
@@ -46,22 +46,18 @@ module.exports.getUploadPUrlPut = async (
 
 // function to generate signed-url for upload(POST)
 module.exports.getUploadPUrlPost = async (filePath, contentType) => {
-  try {
-    const presignedUrl = await getSignedUrl(
-      s3,
-      new PutObjectCommand({
-        Bucket: awsEnv.s3BucketName,
-        Key: filePath,
-        contentType: contentType,
-      }),
-      {
-        expiresIn: 60,
-      }
-    );
-    return presignedUrl;
-  } catch (e) {
-    return e;
-  }
+  const presignedUrl = await getSignedUrl(
+    s3,
+    new PutObjectCommand({
+      Bucket: awsEnv.s3BucketName,
+      Key: filePath,
+      contentType: contentType,
+    }),
+    {
+      expiresIn: 60,
+    }
+  );
+  return presignedUrl;
 };
 
 // function to delete object
diff --git a/src/services/chats.js b/src/services/chats.js
index ca74d774..a9f30ed4 100644
--- a/src/services/chats.js
+++ b/src/services/chats.js
@@ -243,20 +243,8 @@ const uploadChatImgGetPUrlHandler = async (req, res) => {
     });
     const chat = await chatDocument.save();
     const key = `chat-img/${chat._id}`;
-    aws.getUploadPUrlPost(key, type, (err, data) => {
-      if (err) {
-        return res
-          .status(500)
-          .send("Chat/uploadChatImg/getPUrl : internal server error");
-      }
-      data.fields["Content-Type"] = type;
-      data.fields["key"] = key;
-      res.json({
-        id: chat._id,
-        url: data.url,
-        fields: data.fields,
-      });
-    });
+    const data = await aws.getUploadPUrlPost(key, type);
+    res.json({ url: data, id: chat._id });
   } catch (e) {
     logger.error(e);
     res.status(500).send("Chat/uploadChatImg/getPUrl : internal server error");