Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
…520-ban-여부에-따른-서비스-이용-제한
…-kaist/taxi-back into #520-ban-여부에-따른-서비스-이용-제한
kmc7468
requested changes
Sep 2, 2024
kmc7468
requested changes
Sep 2, 2024
src/modules/ban.js
Outdated
| switch (service) { | ||
| case "Rooms/create": | ||
| case "Rooms/join": | ||
| var _serviceName = "service"; |
src/modules/ban.js
Outdated
| .split(".")[0]; | ||
| switch (service) { | ||
| case "Rooms/create": | ||
| var banErrorMessage = `Rooms/create : user ${req.userId} (${req.session.loginInfo.sid}) is temporarily restricted from creating rooms until ${formattedExpireAt}.`; |
There was a problem hiding this comment.
나중에 case가 너무 많아질 것 같아서 염려가 됩니다. Endpoint 이름은 service 변수에 담겨있으니 그것을 사용하면 될 것 같고, 에러 메세지의 경우에는 언제까지 차단됐다는 메세지만 포함해도 괜찮을 것 같습니다. (그리고 제가 알기론 req.userId랑 req.session.loginInfo.sid가 같은 값으로 알고 있어요!)
src/modules/ban.js
Outdated
| const bans = await banModel.find({ | ||
| userSid: req.session.loginInfo.sid, | ||
| expireAt: { | ||
| $gte: req.timestamp, |
There was a problem hiding this comment.
큰 차이는 없을 것 같은데 저는 이럴 때 gte보다는 gt를 사용하는걸 선호하긴 합니다! (expireAt이 이때부터 차단 해제된다는 의미니까요) 이건 그냥 optional로 원하시면 수정해주셔도 될 것 같습니다.
src/modules/ban.js
Outdated
| ); | ||
| return; | ||
| } | ||
| if (banRecord != undefined) { |
cokia
approved these changes
Sep 3, 2024
src/modules/ban.js
Outdated
Comment on lines
35
to
37
| banRecord = bans.reduce( | ||
| (max, ban) => (ban.expireAt > max.expireAt ? ban : max), | ||
| bans[0] |
There was a problem hiding this comment.
디비에서 가져올때 expireAt 순서로 소팅해서 가져오면 불필요한 .reduce()를 줄일 수 있을 것 같아요..!
kmc7468
requested changes
Sep 3, 2024
src/services/rooms.js
Outdated
|
|
||
| const createHandler = async (req, res) => { | ||
| const { name, from, to, time, maxPartLength } = req.body; | ||
|
|
||
| try { | ||
| // 사용자가 방 생성 기능에 대하여 이용 정지 상태인지 확인합니다. | ||
| const banErrorMessage = await validateServiceBanRecord(req, "Rooms/create"); | ||
| if (banErrorMessage != undefined) { |
src/services/rooms.js
Outdated
| @@ -237,6 +246,14 @@ const joinHandler = async (req, res) => { | |||
| .findOne({ id: req.userId }) | |||
| .populate("ongoingRoom"); | |||
|
|
|||
| // 사용자가 방 참여 기능에 대하여 이용 정지 상태인지 확인합니다. | |||
| const banErrorMessage = await validateServiceBanRecord(req, "Rooms/join"); | |||
| if (banErrorMessage != undefined) { | |||
kmc7468
requested changes
Sep 4, 2024
src/middlewares/ban.js
Outdated
| const { validateServiceBanRecord } = require("../modules/ban"); | ||
|
|
||
| const banMiddleware = async (req, res, next) => { | ||
| console.log(`req.originalUrl: ${req.originalUrl}`); |
There was a problem hiding this comment.
저희 로그 남길 땐 logger 사용해야 합니다. 그리고 특이사항이 있는게 아니라면 이 내용은 로깅 안하는게 더 좋을 것 같아요!
src/middlewares/ban.js
Outdated
| const banMiddleware = async (req, res, next) => { | ||
| console.log(`req.originalUrl: ${req.originalUrl}`); | ||
| const serviceMapper = { | ||
| "/rooms/create": "service", |
src/routes/rooms.js
Outdated
| @@ -43,6 +43,9 @@ router.get( | |||
| roomHandlers.infoHandler | |||
| ); | |||
|
|
|||
| // 방 생성/참여전 ban 여부 확인 | |||
| router.use(require("../middlewares/ban")); | |||
There was a problem hiding this comment.
router.use 보다는 각 Endpoint마다 미들웨어를 달아주는게 좋을 것 같아용
There was a problem hiding this comment.
auth middleware 바로 아래로 올리는 것으로 논의 완료
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #520