Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

예상 택시 비용 쿼리 오류 해결 #532

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

ybmin
Copy link
Contributor

@ybmin ybmin commented Aug 13, 2024

Summary

It closes #529

Further Work

  • Do something...

@ybmin ybmin added the 😱 bug Something isn't working label Aug 13, 2024
@ybmin ybmin requested a review from kmc7468 August 13, 2024 14:23
@ybmin ybmin self-assigned this Aug 13, 2024
@ybmin ybmin linked an issue Aug 13, 2024 that may be closed by this pull request
@ybmin ybmin marked this pull request as ready for review August 20, 2024 12:03
@ybmin ybmin changed the title Refactor: fix error 예상 택시 비용 쿼리 오류 해결 Aug 20, 2024
@ybmin
Copy link
Contributor Author

ybmin commented Aug 20, 2024

원인 분석

Mongoose에서 find할 때 callback을 내부에 두면 Promise로 날아오지 않아 쿼리가 완료되지 않은 채 오류가 발생하는 것으로 파악되었습니다. 해당 callback을 삭제하니, 정상적으로 작동하였습니다.

Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수정 감사합니다!

@kmc7468 kmc7468 merged commit ed177db into dev Aug 20, 2024
1 check passed
@kmc7468 kmc7468 deleted the #529-예상-택시-비용-쿼리-오류-해결 branch August 20, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😱 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

예상 택시 비용 쿼리 오류 해결
2 participants