Cutensor #1943
Open
Cutensor #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbennun
requested changes
Feb 21, 2025
| @@ -1,5 +1,4 @@ | |||
| # Copyright 2019-2023 ETH Zurich and the DaCe authors. All rights reserved. | |||
| from dace.library import register_library | |||
| from .nodes import * | |||
There was a problem hiding this comment.
you should not remove this statement from a library init, we use it for querying nodes
There was a problem hiding this comment.
I see I will reintroduce it. I had a circular import issue with them and looked unnecessary in the first glance.
I will reintroduce them and handle the circular import differently.
alexnick83
reviewed
Feb 21, 2025
No, but if you approve the design of tensor transpose, I will update the tensordot too. It is possible that I will do it after SC, and first focus on optimizing index permutations on f2dace/dev branch, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added tensor transpose node for cutensor.
I would like you to review the structure of the changes.
I want to use this change to improve the transpose calls in ECRAD.