Add Support ServerFormPostRedirectStrategy #16551
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes spring-projectsgh-16542 Signed-off-by: Max Batischev <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
Closes spring-projectsgh-16556 Signed-off-by: Max Batischev <[email protected]>
franticticktick
force-pushed
the
gh-16542
branch
from
f5a036c to
df80ff5
Compare
sjohnr
added
in: web
sjohnr
requested changes
Feb 14, 2025
There was a problem hiding this comment.
Thanks @franticticktick, this looks great so far! I added one minor comment for now, and then I will review this more thoroughly before merging and can make any other minor adjustments if I find anything.
| .replace("{{action}}", HtmlUtils.htmlEscape(uriComponentsBuilder.query(null).build().toUriString())) | ||
| .replace("{{params}}", hiddenInputsHtmlBuilder.toString()) | ||
| .replace("{{nonce}}", HtmlUtils.htmlEscape(nonce)) | ||
| .getBytes(Charset.defaultCharset()); |
There was a problem hiding this comment.
I believe we will want to use StandardCharsets.UTF_8 here instead since the html page declares that charset in a <meta> tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-16542