Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive StrictServerWebExchangeFirewall bean not used #16560

Open
gnawf opened this issue Feb 10, 2025 · 0 comments
Open

Reactive StrictServerWebExchangeFirewall bean not used #16560

gnawf opened this issue Feb 10, 2025 · 0 comments
Labels
status: waiting-for-triage An issue we've not yet triaged type: bug A general bug

Comments

@gnawf
Copy link

gnawf commented Feb 10, 2025

Describe the bug
The Reactive Firewall doc mentions

    @Bean
    public StrictServerWebExchangeFirewall httpFirewall() {
        StrictServerWebExchangeFirewall firewall = new StrictServerWebExchangeFirewall();
        firewall.setAllowSemicolon(true);
        return firewall;
    }

But this StrictServerWebExchangeFirewall bean doesn't seem to be used?

In my IDE I can't find any usages of WebFilterChainProxy.setFirewall

Seems similar to #16061 but this issue for ServerWebExchangeFirewall

To Reproduce

Set the ServerWebExchangeFirewall bean per docs.

Expected behavior

The ServerWebExchangeFirewall bean behavior is used.

@gnawf gnawf added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant