DiscoverNewWarehouseTables #12
Open
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squareJake
approved these changes
Feb 27, 2025
| @@ -107,6 +107,10 @@ func (c *Client) apiCallWithBody(endpoint string, method string, jsonParams stri | |||
| } | |||
|
|
|||
| if resp.StatusCode != 200 { | |||
| // Parse header for retry time | |||
| if retryAfter, ok := resp.Header["Retry-After"]; resp.StatusCode == 429 && ok { | |||
| return nil, fmt.Errorf("Too many requests, retry after: %s seconds", retryAfter) | |||
There was a problem hiding this comment.
The anomalo API docs don't say - but hopefully this follows the convention for Retry-After of using seconds? I'm kind of surprised that's the default unit actually - seems pretty coarse for what is probably often a short term issue.
It might also be nice to expose the number of seconds to wait in a custom error (instead of just the message string) so callers can actually wait that long - but not necessary for this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a client method for
Discover new data warehouse tables. As part of this PR, we add some additional (shared) error handling logic. If the request returns a 429 status code, we attempt to parse the response header for theRetry-Aftervalue, which represents how long the user should wait before reissuing a request.