Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CmdStanR 1.0 release #1059

Open
jgabry opened this issue Feb 12, 2025 · 8 comments
Open

CmdStanR 1.0 release #1059

jgabry opened this issue Feb 12, 2025 · 8 comments

Comments

@jgabry
Copy link
Member

jgabry commented Feb 12, 2025

It came up in on the forum that CmdStanR not being at v1.0 gives the impression that the API isn't considered stable yet.

@andrjohns @SteveBronder what do you think about going ahead with the 1.0 release?

Is there anything you want to get in before we do that? I think it would be good to get #1022 merged, although I guess we could do 1.0 without it and merge it after. Anything else?

@andrjohns
Copy link
Collaborator

On board with 1.0 soon! One thing we did chat about before for a CRAN release was removing the backwards compatibility so that we're starting with a simpler codebase, but not sure how essential that is

One other minor thing that I want to test out and open up a PR for is extending #1054 for RTools{40,42,43}. From my testing in the original Math PR it was compatible with the Math stuff, but just want to double-check with cmdstan/cmdstanr.

If that has no issues, and we can restrict compatibility to cmdstan >= 2.35.0, then we could also remove all of the custom toolchain installation/handling on windows

@jgabry
Copy link
Member Author

jgabry commented Feb 12, 2025

On board with 1.0 soon! One thing we did chat about before for a CRAN release was removing the backwards compatibility so that we're starting with a simpler codebase, but not sure how essential that is

Oh, good point. We should do this. I can work on it.

One other minor thing that I want to test out and open up a PR for is extending #1054 for RTools{40,42,43}. From my testing in the stan-dev/math#2999 it was compatible with the Math stuff, but just want to double-check with cmdstan/cmdstanr.

Sounds good.

If that has no issues, and we can restrict compatibility to cmdstan >= 2.35.0, then we could also remove all of the custom toolchain installation/handling on windows

Yeah that would be great!

@SteveBronder
Copy link
Collaborator

A few things I'd like to have/try before we do a 1.0 release

  • Improve Handling of cpp_options #1022 (@katrinabrock I really apologize for my tardiness on that)
  • Instead of starting N cmdstan processes I'd really like to give using cmdstan internal multithreading across chains a go. It should be a nice speed update for users. We can always backup to multiple cmdstan instances if need be
  • Feature/reduce mem pathfinder stan#3325 adds a new column to pathfinder's output so we will need to account for that in the code

@jgabry
Copy link
Member Author

jgabry commented Feb 12, 2025

A few things I'd like to have/try before we do a 1.0 release

Agree this would be great to get in.

  • Instead of starting N cmdstan processes I'd really like to give using cmdstan internal multithreading across chains a go. It should be a nice speed update for users. We can always backup to multiple cmdstan instances if need be

How much work do you think it would be to do this?

Sounds good

@SteveBronder
Copy link
Collaborator

How much work do you think it would be to do this?

A lot. Let's have that be a "would be nice" but not totally necessary.

@katrinabrock
Copy link

Is making the package CRAN-ready a goal eventually? Or is it not intended to be on CRAN?

@andrjohns
Copy link
Collaborator

Yep, CRAN is a goal

@katrinabrock
Copy link

Cool! I feel like that will help a lot because then you can look at Reverse Depends to see how people are actually using it. (Far from exhaustive, of course, but better than not having that info.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants