Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulate locking for WriteKey and ReadKeys within class. #13

Open
matthewvon opened this issue Jul 9, 2020 · 1 comment
Open

Encapsulate locking for WriteKey and ReadKeys within class. #13

matthewvon opened this issue Jul 9, 2020 · 1 comment

Comments

@matthewvon
Copy link
Member

Alex noted that the initial locking around WriteKey and ReadKeys is ugly and somewhat unsafe. This is a reminder that we agreed to go back and make these two std:: objects into classes that include read/write locks and exception management in a future PR.

@toktarev
@toktarev toktarev self-assigned this Jul 9, 2020
@toktarev
Copy link

#14

@toktarev toktarev removed their assignment Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthewvon @toktarev