Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing old marked version #69

Open
fokusferit opened this issue Jan 4, 2019 · 3 comments
Open

Installing old marked version #69

fokusferit opened this issue Jan 4, 2019 · 3 comments

Comments

@fokusferit
Copy link

Over the last 12 months the marked library fixed a couple of issues, regarding security, performance and also regExr.

Currently I'm facing the following problem when using Addon-Info in Combination with a Github Flavored Markdown:

Using Inner HTML at the beginning results in the issue that the rules.html Regular Expression from Marked is only able to recognize one Inner HTML item, afterwards it fails.

As an example, below is the Markdown result of Storybook + Addon-Info for our README which starts with the following Markdown:

<p align="center">
<img src="https://raw.githubusercontent.com/fabric-design/scss/master/fabric-logo.png"/>
</p>

<p align="center"></p>
=======

#### A set of React UI components for Retail Operations department.

#### Current Stewards:

results in the Following:

screen shot 2019-01-04 at 15 49 53

but it should look like this:

screen shot 2019-01-04 at 15 51 00

Solution:

Can we update your package.json dependency of marked to 0.6.0 ?

Issue:

Using the ^ (carat) with a leading Zero in npm semver results in only patch update cycle, this means, the last version npm installs is 0.3.19 and not 0.6.0. This might be intended or not (as I didn't knew that the carat operator behaves different between a leading Zero and 1).

@ndelangen
Copy link
Member

@fokusferit I tried upgrading, but it has a bad effect on the support for inline elements such as <span> and <font> within markdown blocks.

If you make sure there a blank line between your html & markdown the above code should work I think.

@christianalfoni
Copy link
Collaborator

I will try to find some time to get down the latest marked here and see what we can do about the evaluation :)

@patsplat
Copy link
Contributor

patsplat commented Sep 2, 2020

This PR patches marked #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants