Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure teleporting bodies notify bepu's data structure #2650

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Ensure teleporting bodies notify bepu's data structure #2650

wants to merge 1 commit into from

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented Feb 22, 2025

PR Details

We have to explicitly notify bepu when moving a body, even more so when sleeping, otherwise its internal representation inside the physics scene is not updated, leading to misses when doing physics tests

Related Issue

fix #2649

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren mentioned this pull request Feb 22, 2025
Open
@Eideren Eideren changed the title fix: Ensure teleporting bodies notifies bepu's data structure fix: Ensure teleporting bodies notify bepu's data structure Feb 22, 2025
@luca-domenichini
Copy link

@Eideren maybe the same fix should be applied to Orientation property?

stride/sources/engine/Stride.BepuPhysics/Stride.BepuPhysics/BodyComponent.cs

Line 249 in 257d6af

public Quaternion Orientation

And maybe, it would be even better to have a method to set Position and Orientation in just one call, to minimze calls to bodyRef.UpdateBounds(); internally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bepu Physics - Raycast does not intercept Entity with BodyComponent
2 participants
@Eideren @luca-domenichini