-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance? #26
Comments
There’s also some C++ version that doesn’t do teams but is ~200× faster → https://github.com/JesseBuesking/trueskill#benchmark . |
At a random guess I'd say you're just looking at the difference between Python and C++ in terms of performance. But I'm guessing if you were keen you could profile both of them and look for the bottlenecks, try doing a flame graph, very informative: |
Very cool, I’ll try that! Thanks. =) |
When I implemented it, performance was not one of the goals. The goal is to implement the TrueSkill algorithm with clean code for ease of understanding. If you need better performance, another implementation (perhaps, with another language) will be helpful rather than this project. |
Hello!
Thank you for this wonderful piece of code. =)
Have you tried tuning the performance?
E.g. for 10,000 random matches (each of max. 5 teams of max. 10 members each) it consistently takes:
rate()
),quality()
)… on 4 cores (and 4 parallel
python3
processes).The text was updated successfully, but these errors were encountered: