Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Fix deserialize_any and serde-transcode support #2

Open
1 of 2 tasks
sunny-g opened this issue Jun 8, 2019 · 0 comments
Open
1 of 2 tasks

Fix deserialize_any and serde-transcode support #2

sunny-g opened this issue Jun 8, 2019 · 0 comments

Comments

@sunny-g
Copy link
Owner

sunny-g commented Jun 8, 2019

Two things are flawed with the current implementation:

  • deserializing tuples just fails (since it delegates to deserialize_seq which expects a list. This is an easy problem to "solve" though it leaves much to be desired. Updated to just deserialize to a list in 51ccd12
  • we cannot deserialize "anonymous" enums or structs at all (using serde-transcode):
    • the first thing it does is call deserialize_any on the provided Deserializer
    • its passes a Visitor impl that doesn't implement a visit_enum method
    • even if it did, it eventually will call a method on the associated (i.e. our) Serializer like serialize_unit_variant, which requires &'static str, which the Visitor (probably?) cannot provide
@sunny-g sunny-g changed the title Fix deserialize_any Fix deserialize_any and serde-transcode support Jun 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant