fix: recurse into $derived for ownership validation
#15166
Merged
+168
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67dc579 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
- `$derived` can contain `$state` declarations so we cannot ignore them, so this reverts #14533 - instead, we add equality checks to not do this expensive work unnecessarily - this also adds a render effect similar to the class ownership addition when it detects a getter on a POJO during ownership addition fixes #15164
dummdidumm
force-pushed
the
ownership-derived-fix
branch
from
e35f074 to
f0bb9c5
Compare
|
Thanks for the quick fix. Could you have a look at this case as well? |
|
Mhm, honestly I think this is a case which we cannot solve. But also, if you're passing along a thunk, you may also pass an update function. |
Rich-Harris
reviewed
Feb 3, 2025
packages/svelte/tests/runtime-runes/samples/non-local-mutation-with-binding-8/main.svelte
Outdated
Show resolved
Hide resolved
Rich-Harris
approved these changes
Feb 3, 2025
|
Did this PR go stale? |
|
No - I just didn't see Rich approved it; thanks for the reminder 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$derivedcan contain$statedeclarations so we cannot ignore them, so this reverts fix: don't try to add owners to non-$stateclass fields #14533fixes #15164
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint