Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ever considered to add school vacations? #146

Open
dusiema opened this issue Nov 13, 2020 · 2 comments
Open

Ever considered to add school vacations? #146

dusiema opened this issue Nov 13, 2020 · 2 comments

Comments

@dusiema
Copy link
Contributor

dusiema commented Nov 13, 2020

Hey @svendiedrichsen,
Thank you for your work on this lib and open sourcing it.

Have you ever considered to add school vacations to this lib?
Even if you don't want to do it would you be open to accept pull-requests to this?
I am not saying I will do it right away - I was just curious. :-)

(Sorry if miss-used an issue to ask this question.)

@grexe
Copy link

grexe commented Apr 7, 2021

on a related note, and to make this a full issue, so @dusiema need not worry:), 15. November is only a school holiday in Vienna, Austria, but not an official holiday:
https://github.com/svendiedrichsen/jollyday/blob/master/src/main/resources/holidays/Holidays_at.xml#L66

@dusiema
Copy link
Contributor Author

dusiema commented Apr 7, 2021

I wonder if jollyday is still alive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants