Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/fixer): Wrap object tagged templates #9991

Merged
merged 3 commits into from
Feb 5, 2025
Merged

fix(es/fixer): Wrap object tagged templates #9991

merged 3 commits into from
Feb 5, 2025
+34 −0

Conversation

magic-akari
Copy link
Member

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 443f676

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 added this to the Planned milestone Feb 5, 2025
@magic-akari magic-akari marked this pull request as ready for review February 5, 2025 03:54
@magic-akari magic-akari requested a review from a team as a code owner February 5, 2025 03:54
@kdy1 kdy1 requested a review from a team as a code owner February 5, 2025 04:09
kdy1
kdy1 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 enabled auto-merge (squash) February 5, 2025 04:09
@kdy1 kdy1 merged commit 963c3a5 into swc-project:main Feb 5, 2025
170 checks passed
@magic-akari magic-akari deleted the fix/issue-9930 branch February 5, 2025 05:21
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 5, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9991 will degrade performances by 6.76%

Comparing magic-akari:fix/issue-9930 (443f676) with main (9c89d57)

Summary

❌ 3 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ es/full/minify/libraries/moment 119.4 ms 128.1 ms -6.76%
❌ es/lints/libs/react 1.7 ms 1.7 ms -4.68%
❌ es/minifier/libs/jquery 156.3 ms 164.2 ms -4.82%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
Planned
Development

Successfully merging this pull request may close these issues.

minifier: Removing parentheses around objects and tagged templates causes syntax errors
2 participants
@magic-akari @kdy1