Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(plugin): Try wasmer/js to reduce binary size #9993

Closed
wants to merge 1 commit into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 5, 2025

@kdy1 kdy1 added this to the Planned milestone Feb 5, 2025
@kdy1 kdy1 self-assigned this Feb 5, 2025
Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 17d8a1a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1
Copy link
Member Author

kdy1 commented Feb 5, 2025

error: The `js` feature must be enabled only for the `wasm32` target (either `wasm32-unknown-unknown` or `wasm32-wasi`).
   --> /Users/kdy1/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wasmer-5.0.5-rc1/src/lib.rs:436:1
    |
436 | / compile_error!(
437 | |     "The `js` feature must be enabled only for the `wasm32` target (either `wasm32-unknown-unknown` or `wasm32-wasi`)."
438 | | );
    | |_^

It was for wasm build

@kdy1 kdy1 closed this Feb 5, 2025
@kdy1 kdy1 deleted the wasmer-js branch February 5, 2025 07:28
Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #9993 will degrade performances by 3.83%

Comparing kdy1:wasmer-js (17d8a1a) with main (963c3a5)

Summary

❌ 1 regressions
✅ 195 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/minifier/libs/moment 97.3 ms 101.1 ms -3.83%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Use ‘wasmer/js’ when applicable to reduce binary size
1 participant