[Bug]: Advanced Manual Setup for LN channel can result in crash

[catch-21]

Describe the bug

Bitkit crashes if the Manual Setup flow form is not filled in and the Continue button is pressed.
(This may have persistently broken ldk, need to test more)

Reproduce

1. Go to Advanced settings -> Lightning Connections -> Add Connection
2. At Manual Setup page, tap 'Continue'
3. App crashes
4. On restarting Bitkit the LDK node never starts correctly (wallet restore required)

Screenshots / Recording

Simulator.Screen.Recording.-.iPhone.15.-.2024-09-26.at.22.23.35.mp4

Screen.Recording.2024-09-27.at.13.18.01.mov

Operating system

iOS / Android

Bitkit version

1.0.5 (136)

Log output

crash-report.txt

[pwltr]

Can confirm, the app is crashing when trying to add a peer with an invalid pubkey. I can add validation to check for correct length but that's not enough to prevent this. @Jasonvdb FYI

Simulator.Screen.Recording.-.iPhone.15.-.2024-09-26.at.22.23.35.mp4

crash-report.txt

[pwltr]

Crashing on Android as well:

Screen.Recording.2024-09-27.at.13.18.01.mov

[Jasonvdb]

Yeah length check doesn't seem like enough here. Needs proper validation.

[Jasonvdb]

This should do the trick: synonymdev/react-native-ldk#274

I'm testing with 0000000000000000000000000000000000000000000000000000000000000000

[catch-21]

@pwltr It's interesting you get a crash on android because I see a toast (real device)

A fix must be tested on both platforms

[Jasonvdb]

Still strangely stopped being able to replicate the crash since Friday but I believe this does the trick: #2275

Using the actual curve to validate the public key.

[catch-21]

Unable to reproduce crash on android using 0d67faa

• The form validation now prevents proceeding without inputting a valid node id, and something for host and port.
• If an node id is used that cannot be connected to then an appropriate toast error is displayed

---

Tested again on Android and iOS using release 1.0.5 (137)