Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve expo example #851

Closed
1 of 6 tasks
juliusmarminge opened this issue Jan 27, 2024 · 5 comments
Closed
1 of 6 tasks

feat: improve expo example #851

juliusmarminge opened this issue Jan 27, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@juliusmarminge
Copy link
Member

juliusmarminge commented Jan 27, 2024

Describe the feature you'd like to request

the idea of the expo example was never to have a perfect mobile setup from the start, but more to show the splitting possible.

but i tihnk we can add some stuff that will enhance the user experience of mobile devs checking this out

Describe the solution you'd like to see

  • light/dark mode (chore(expo) : Update to Expo 50 #795)
  • modals/drawers?
    • other navigation primitives that's commonly found in mobile apps?
  • auth (feat: expo auth #720)
    • maybe this can be refactored with api routes available directly in expo? that way we wouldn't need to deal with cross-origin stuff on the nextjs app? don't know if that makes sense though as you'd then have 2 server deployments ://
  • keyboard avoiding when writing in input fields
  • more??
  • [ ]

Additional information

https://github.com/supabase-community/create-t3-turbo got some of these I believe

@juliusmarminge juliusmarminge added enhancement New feature or request good first issue Good for newcomers labels Jan 27, 2024
@EuanMorgan
Copy link
Contributor

EuanMorgan commented Feb 6, 2024

Could possibly add Apple sign in to this?
Just because its in Apple's ToS now that apps must offer it if they use any third party auth like the discord provider here

@juliusmarminge
Copy link
Member Author

Yup - i just dont have an Apple developer account so cant test it 😆

@trevorpfiz
Copy link

I am working on this. thoughts on using react-native-reusables? best 'shadcn/ui for React Native' I have found.

@trevorpfiz
Copy link

for the keyboard avoiding, this thread sums up the best options. it matches my experience.

we should probably just use react-native-keyboard-aware-scroll-view for a demo as it works with Expo Go? can recommend the other options in the FAQs?

@trevorpfiz
Copy link

Could possibly add Apple sign in to this? Just because its in Apple's ToS now that apps must offer it if they use any third party auth like the discord provider here

I am trying to add Apple sign-in, but running into two issues:

  1. Apple provider OIDC response body error nextauthjs/next-auth#9989
  2. [Apple] PKCE code_verifier cookie was missing nextauthjs/next-auth#6898 (reply in thread)

@t3-oss t3-oss locked and limited conversation to collaborators Apr 7, 2024
@juliusmarminge juliusmarminge converted this issue into discussion #967 Apr 7, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants