Normative: Account for TypedArraySpeciesCreate species lookup #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The rendered spec for this PR is available at https://tc39.es/proposal-immutable-arraybuffer/pr/47. |
|
Returning a zero-length, immutable TypedArray from https://tc39.es/ecma262/#sec-%typedarray%.from and https://tc39.es/ecma262/#sec-%typedarray%.of is still allowed with this change. Is this intentional? I think I'd prefer if those two methods match the methods calling TypedArraySpeciesCreate. |
…ment in %TypedArray%.{of,from}
|
It was intentional, but I can't remember why. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46 by adding an optional accessMode parameter to TypedArraySpeciesCreate and passing in WRITE from %TypedArray%.prototype.{filter,map,slice} (but not from %TypedArray%.prototype.subarray, which returns without attempting any buffer manipulation). When the new parameter is WRITE, the result from TypedArrayCreateFromConstructor is enforced to be mutable.