Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anyone can reset the prepared shares countdown for any other user #60

Closed
ethereumdegen opened this issue Nov 25, 2024 · 2 comments
Closed

Anyone can reset the prepared shares countdown for any other user #60

ethereumdegen opened this issue Nov 25, 2024 · 2 comments
Labels
fix_approved

Comments

@ethereumdegen
Copy link
Collaborator

because it is possible to deposit on behalf of other users, anybody can reset each other's coundtowns by depositing small amounts on their behalf, DoSing withdrawals. Most of the protocols that include withdrawal queues force users to make two transactions: the withdrawal request and the actual withdrawal, which would make it optimal in this situation as you want to allow deposits on behalf of other users
@ethereumdegen
Copy link
Collaborator Author

ethereumdegen commented Nov 25, 2024 •
edited
Loading

could just ONLY reset countdown if msgsender == lender ?

no -- this wont work

@ethereumdegen
Copy link
Collaborator Author

ethereumdegen commented Nov 25, 2024 •
edited
Loading

see branch fix/issue-60 #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix_approved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ethereumdegen