Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can pre-prepare shares for themselves by flash-borrowing shares #61

Closed
ethereumdegen opened this issue Nov 25, 2024 · 2 comments
Closed

Comments

@ethereumdegen
Copy link
Collaborator

the other issue is that people can 'prepare shares' for themselves without actually owning any shares by borrowing shares from someone else in a 'flash loan' kind of scheme .

so the optimal way to operate is to always pre-prepare shares for yourself with this method -.-

POTENTIAL FIX: wipe out a users prepared shares if they transfer shares out of their account ?

@ethereumdegen
Copy link
Collaborator Author

look at erc4626

@ethereumdegen
Copy link
Collaborator Author

ethereumdegen commented Nov 25, 2024

see branch fix/issue-60 #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant