Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block_duration_minutes option no longer working in the version > 3.7.0 #511

Closed
serhii-shnurenko opened this issue Aug 26, 2020 · 1 comment · Fixed by #512
Closed

block_duration_minutes option no longer working in the version > 3.7.0 #511

serhii-shnurenko opened this issue Aug 26, 2020 · 1 comment · Fixed by #512

Comments

@serhii-shnurenko
Copy link

👻 Description

After adding hardcoded instance_interruption_behavior:stop option to spot request, block_duration_minutes option no longer working

instance_interruption_behavior: "stop",

error message:

>>>>>>     Failed to complete #create action: [Could not create a spot instance:
The parameter BlockDurationMinutes cannot be specified when the instanceInterruptionBehavior is set to 'STOP'.] on default-centos-7

Versions

test-kitchen (2.6.0)
kitchen-ec2 (3.7.1)

Environment

kitchen.local.yml

driver:
  name: ec2
  region: us-west-2
  instance_type: "t3.small"
  spot_price: '0.010'
  spot_wait: 600
  aws_ssh_key_id: <my-ssh-key>
  block_duration_minutes: 120
  shared_credentials_profile: <my_aws_profile>
  block_device_mappings:
    - device_name: /dev/sda1
      ebs:
        volume_size: 16
        delete_on_termination: true


platforms:
  - name: centos-7
    transport:
      name: rsync
      username: centos
      ssh_key: ~/.ssh/<my-ssh-key>

  - name: amazon2
    transport:
      name: rsync
      username: ec2-user
      ssh_key: ~/.ssh/<my-ssh-key>

Please consider making instance_interruption_behavior option configurable, or change to terminate in case block_duration_minutes option is set.

@serhii-shnurenko serhii-shnurenko changed the title Broken block_duration_minutes option no longer working in the version > 3.7.0 block_duration_minutes option no longer working in the version > 3.7.0 Aug 26, 2020
@clintoncwolfe
Copy link
Contributor

Thanks for the report. I'm able to reproduce the problem and I'm looking to see what can be done.

bryceml pushed a commit to bryceml/salt that referenced this issue Sep 25, 2020
dwoz pushed a commit to saltstack/salt that referenced this issue Sep 29, 2020
clrpackages pushed a commit to clearlinux-pkgs/salt that referenced this issue Nov 10, 2020
Ahmadulin Andrey (1):
      Update url link in documentation in vault.py

Akmod (1):
      filter_by supports list fix (#56689)

Alan J Cugler (1):
      clarifying the pillar_opts is configured on both master and minion.

Alan Somers (1):
      Revert "fix 45195 - add ignore to sysctl state and module"

Alberto Planas (2):
      kubeadm: detect empty token lists
      Fix __mount_device wrapper

Alexander Graul (3):
      spacewalk runner: remove Python2/import comments
      Accept nested namespaces in spacewalk.api
      Add spacewalk runner command parsing tests

Alexander Shemetov (2):
      %PATH% manipulation with EnVar Plugin for NSIS
      Minor change

Alexander Weidinger (4):
      Fix x509 CRL creation (fixes #54867)
      Run pre-commit on x509 module
      Allow x509.certificate_managed to use a CSR
      Run pre-commit on x509 state

Ali Rizvi-Santiago (10):
      Removed line to potentially fix issue saltstack/salt#57790 in the salt.states.win_system module.
      Added changelog mentioning the fix for issue saltstack/salt#57790.
      Check the type of the data passed to salt.matcher.confirm_top is a list instead of assuming an implicit false is a "bad data" error.
      Revert "Check the type of the data passed to salt.matcher.confirm_top is a list instead of assuming an implicit false is a "bad data" error."
      Removed the unnecessary test as suggested by @waynew.
      Added a unit test under unit.matchers.test_confirm_top.
      Fixed lint issues in tests/unit/matchers/test_confirm_top.py.
      Fixed some lint issues in the tests.unit.matchers.confirm_top unit test.
      Blackened lint fixes to the salt.matchers.confirm_top module, and its corresponding unit test at tests.unit.matchers.test_confirm_top.
      Added changelog entry for issue #54882.

Andreas Thienemann (1):
      Fix tuned module on RHEL/CentOS 7.8

Andrei Mahalean (1):
      Allow to use a custom port in Proxmox connection

Andrei Zene (3):
      Fix executors not being called for multi-jobs
      fixup! Fix executors not being called for multi-jobs
      fixup! fixup! Fix executors not being called for multi-jobs

Anthony Arnaud (1):
      fix 46902: wait dpkg lock (#52378)

Ari Maniatis (1):
      Dropped != Deprecated

AsocPro (2):
      Update standalone minon documentation
      Add missing )

Barney Sowood (2):
      Add changelog entry for PR 54067
      Re-run pre-commit hooks

Bart (1):
      Fix link to Proxmox website

Benjamin Drung (24):
      Fix parsing version of virtualenv
      Drop six usage and Py2 support
      Fix spelling mistake of related
      Fix spelling mistake of specifying
      Fix spelling mistake of overridden
      Fix spelling mistake of connection
      Fix spelling mistake of destroy
      Fix spelling mistake of minimum
      Fix spelling mistake of whether
      Fix spelling mistake of against
      Fix spelling mistake of algorithm
      Fix spelling mistake of compatible
      Fix spelling mistake of compatibility
      Fix spelling mistake of default
      Fix spelling mistake of documentation
      Fix spelling mistake of environment
      Fix spelling mistake of specify
      Fix spelling mistake of which
      Fix spelling mistake of non-existing
      Fix spelling mistake of definition
      Support testing against system installed version (#57764)
      Fix spelling mistake of default
      Fix spelling mistake of configuration
      Fix spelling mistake of executes

Bo Maryniuk (1):
      Port #50553 to master

Brendan Early (2):
      Add COPR support to states.pkgrepo (#57259)
      Run pre-commit hooks

Bruno Costa (3):
      Fix bad whitespace
      fixing bad pre-commit
      Installed new pre-commit. errors excluded.

Bruno Figueiredo da Costa (4):
      Changes for BUG opened: 56995
      Fix the use of " " on params["filter"].
      Fix the use of " ", in params, with filter. (second fix)
      Added unittest: test_get_mediatype

Bryce Larson (23):
      Update to the latest salt-bootstrap release, v2020.06.23
      fix gce cloudtest
      fix linode cloudtest
      add macos-catalina ci file
      Improve toml docs
      add freebsd pipelines
      hard-code ami ids
      update amis
      update centos8 ami
      add newer versions of google custom search engines
      update arch ami
      update amis: install 7zip, update nox, install cronnie
      switch to vlc for pkg testing on windows so we don't interfere with 7zip
      fix spot instance creation until https://github.com/test-kitchen/kitchen-ec2/issues/511 is fixed
      use spot instance for windows2019
      fix pre-commit on #58505
      fix pre-commit on #57642
      fix pre-commit for #56054
      update library to master-1.9 for the docs job change
      fix pre-commit on #57996
      update irc logs url
      fix pre-commit on #58076
      fix pre-commit on #58066

C. R. Oldham (5):
      Bail out early if we try to load a .pyc that is for a different Python
      Linter fooled me
      Remove f strings
      Cleaner implementation.
      Bail out early if we try to load a .pyc that is for a different Python

Cesar Augusto Sanchez (1):
      Update mysql_database state to work in test mode.

Charles Kenney (9):
      add linode apiv4 support
      add docs
      fix docs typo
      use timeout in linode tests
      fix linter errors
      add changelog entry
      exclude LinodeAPI class members from docs
      add User-Agent to linode salt-cloud module
      fix typo in CloudTest#setUp docstring

Charles McMarrow (4):
      fix msg_pack (#57571)
      Update cmdmod.py
      move_dep_from_module_run (#58701)
      Revert "move_dep_from_module_run (#58701)" (#58702)

Christian McHugh (19):
      allow result parsing in unless/onlyif
      make pre-commit happy
      Documentation update on baredocs (#57503)
      Pass cmd.run arguments to onlyif/unless cmd
      fix rendering of map files from saltenv
      add changelog entry
      satisfy pre-commit
      pre-commit test
      Support only displaying test failures
      add changelog
      pre-commit test
      Fix uses decrement and add local sdb check on kv v2
      fix test setup
      add changelog
      improve test setup
      black updates
      update tests to not pass sdb profile to vault server
      satisfy pre-commit
      pre-commit tests

Cristian (1):
      modules/opkg: create restartcheck state if it's dir doesn't exist

Cristian Hotea (1):
      modules/nilrt_ip.py: Make DNS optional in set_static_all (#58479)

Cédric Bosdonnat (25):
      Fix network unit.states.test_network.test_managed
      pylint: allow a few more 3rd party modules
      Update virt module and states and their tests to python3
      Update libvirt-events code for python3
      libvirt events engine: constant fixes
      Move virt.init boot_dev parameter away from the kwargs
      virt: handle boot device in virt.update()
      virt: add boot_dev parameter to virt.running state
      virt.init: fix the name of volumes reused in disk-types pools
      virt.init: cdrom format default to raw
      virt.init: fix disk target names
      virt.update: handle changing cdrom images for devices with remote source
      Remove buggy start parameter from virt.pool_running docstring
      virt: add debug log with VM XML definition
      Add xmlutil.get_xml_node() helper function
      Add salt.utils.data.get_value function
      Add change_xml() function to xmlutil
      virt.update: refactor the XML diffing code
      virt.test_update: move some code to make test more readable
      virt: convert volumes to disks for xen
      Add pool and volume names to virt._get_all_volumes_paths
      virt.get_disk: show pools and volumes if possible
      Fix virt update when cpu and memory are changed
      virt: use the pool path in case the volume doesn't exist
      Properly fix memory setting regression in virt.update

Dafydd Jones (2):
      Fix docstring examples that had been erroneously changed
      Apply pre-commit suggestions

Daniel A. Wozniak (22):
      Temporary skip to get centos 8 tests to pass
      Add force option to grains module delkey and delval
      Add changelog and docs for 57718 fix
      Blacken test file
      Fix saltcheck ssh test
      Fix CVE-2020-16846
      Open files with proper permissions
      Add cve id to changelog
      cve-2020-17490 consistancy hotfix
      Blacken changed files
      Blacken changed files
      Add attributions and dependencies file
      Fix dependencies link in readme
      Add dates of copyright to dependencies
      Tests and fix for CVE-2020-25592
      Do not overwrite master keys
      Test loader namespaceing
      Honor loaded_base_name
      fix pre-commit
      Blacken changed files
      Isort changed files
      Fix pre-commit

David Florness (1):
      Fix line number

David Murphy (10):
      [WIP] base level before writing tests
      [WIP] Package signing test for RHEL 8,7 and Amazon 2
      [WIP] signing RHEL 7 & 8 rpms
      [WIP]  resolving issues
      [WIP] Updated rpmbuild module works with RHEL 8 and 7
      Tests for package signing for Redhat 7, 8 and Amazon Linux 2
      Updated for pre-commit and docs
      Update for pre-commit changes
      Renamed test file to allow for  BadTestModuleNamesTestCase
      Correct typo in spelling enable_fqdns_grains

Dmitry Kuzmenko (26):
      Partially revert "Port #53452 to master"
      File state: skip symlink file permissions on linux
      Update docs and changelog
      Ignore dir-targeted symlinks as well + test update
      Fixed docs formatting.
      Attempt to catch an error on Debian based distros
      Use hashutils and stringutils for bytes to unicode conversion.
      Test for artifactory changes.
      Daemons wrongly set six.string_types to (str, bytes)
      Ran pre-commit hook
      Fixes for issues found by tests.
      Fixed ec2 cloud unit test.
      Unit test for pwdata_decrypt.
      Fixed tests with M2Crypto.
      Ran pre-commit hook
      Add/update changelog
      Added list target type support to the `scan` roster.
      Added chengelog
      A minor optimization.
      Ran pre-commit on the changed files
      Corrected a mistype
      Fix for system.set_computer_desc test
      Port #49697 and #49926 to master (#56893)
      applied pre-commit
      Applied pre-commit
      Fix for zipped custom modules (#57759)

Eike Waldt (1):
      fix missing quotation mark in salt.states.cmd docs

Elias Probst (1):
      Update links to Jinja docs

Eric Moncada (3):
      fix(module/ini_manage): newline character bug #53534, run pre-commit hooks
      fix(linting): errors
      chore(pre-commit): remove uncessary default param, include isort changes

Eric Robeson@saltit-or1-workspace-01 (2):
      Update artifactory module to handle py3 encoding
      add changelog file

Erik Johnson (27):
      Add documentation for double-indentation of multi-line strings
      Fix dict being changed during iteration
      Restore "gid_from_name" and put on a deprecation path
      Add network teaming support (and clean up bond support) for RHEL/CentOS
      Remove rh_major references to EL5 and EL6
      Fix logic error in auto_addr, use devicetype *only* for team/teamport
      Update network state unit tests to reflect changes to state func
      Update rh_ip module tests to reflect fixes
      Rename team_devicetype to devicetype as it is not teaming-specific
      Warn when using incorrect value "addr" for hwaddr
      Remove build_bond and get_bond from rh_ip
      Add version 3002 release notes
      Add new release notes to doctree
      Remove tests for get_bond, build_bond for rh_ip
      Add changelog file
      Tweak wording in changelog file
      file.serialize state: fix corruption when using msgpack serializer
      Add changelog entry
      Remove incorrect documentation
      Remove comment referencing _supported_dists from salt/grains/core.py
      Properly handle SameSite attribute in parse_cookie_header
      Add note to pushover returner docs
      Add changelog entry
      Precommit
      More precommit
      debian_service: remove support for old, EOL debian releases
      precommit

Firefly (1):
      use null in sls file to map None object

Frode Gundersen (22):
      Update man pages for 3001.1
      Update Changelog and Releasenotes for the 3001.1 release
      Changelog update
      Changelog/Releasenotes update 3001.2
      Add man_pages 3001.2
      Update man pages 3001.3
      Update changelog / releasenotes 3001.3
      Update RC Install Instructions
      Update man-pages to 3002
      Update Reference Magnsium
      Update index.rst
      Update Changelog 3002
      Update Releasenotes 3002
      Update 3002.rst
      Update 3002.rst
      Update 3002.rst
      Update 3002.rst
      Update 3002.rst
      Update 3002.rst
      ChangelogUpdate
      Update for 3002.1 Release
      Update releasenotes

Gareth J. Greenaway (79):
      [master] Fix to thin.generate runner function (#56610)
      moving import salt.modules.vsphere into virtual so we have access to test proxytype in opts.  Gating the check with salt.utils.proxy.is_proxytype.  Adding tests.
      Adding changelog file.
      requested changes.
      Requested changes.  Additional test for the False state.
      Fixing a typo, the first checkout should return an empty dict not None if opts does not include proxy.
      The fail_with_changes state should use the comment argument when passed.  Additional tests.
      Adding changelog file
      Running pre-commit against changes.
      Ensure that kwargs is a copy and not a reference to avoid having __pub_fun_args duplicated on each run.
      Adding changelog.
      Adding a test for cimc proxy.
      Adding tests for ipv6 releated smb changes.
      Updating the test_raw_incron test to reflect changes.
      Disable fqdns grain for proxy minions
      Adding changelog file.
      Need additional default opions for proxy minions.
      removing extra definition for _DFLT_FQDNS_GRAINS
      Adding some tests for the changes to list_repos and expand_repo_def.
      Updating test_linux_gpus to include display controller changes.
      Update linode.rst
      Fixing pillar caching when pillar environments are involved.  adding a test.
      Adding changelog
      Need to check that the reactor system is available before attempting to run any of the reactor runner functions.  Adding tests.
      Adding changelog.
      Updating reactor runner integrations tests per changes.  Updating run_run_plus to be able to override opts.
      Fixing failing tests.
      Additional tests for #58384.
      Removing this extra logging statement.
      Ensure thin_dir is available.
      ensure master_tops is available.
      Need to ensure cachedir and fsclient are preserved throughout the call.
      Increase self.wait timeout in the test_clean_by_request to 30 seconds.
      bump timeouts up to 60 seconds.
      Removing the timeouts from self.wait.  Bumping up the sleep before yielding the eventpublisher_process from 2 seconds to 8 seconds.
      Make sure we repopulate __utils__ on Windows when a job is run from the scheduler
      Adding changelog.
      only run test on Windows since we are testing schedule.handle_func on Windows.
      Patching self.schedule.standalone instead of setting it.
      Fixing stalekey engine so it deletes the keys when they are a list. Breaking out various functionality so it's easier to test. Writing tests.
      Running isort and black.
      Adding a test for stalekey engine changes.
      Adding changelog.
      Adding some missing entries to the changelog.
      Removing duplicate changelog entries.
      Removing duplicate entries to changelog.
      Adding changes to support deltaproxy.
      Adding missing schedule config file for proxy tests.
      No reason for this test to be a slow test.
      removing import comments
      Removing import comments, running isort and black.
      Fix when multiple sources include HTTP and are missing (#58441)
      Raise SaltClientError in parse_host_port so it is caught and handled properly when the minion is connecting to the master.  Updating tests.
      Adding changelog file
      Revert SaltClientError back to ValueError, add an except catch for ValueError further up.
      Updating test to checking for ValueError instead of SaltClientError.
      Adding an additional test for prep_ip_port.  Updating test for parse_host_port to test an invalid port.
      [master] Ensure proxy_config reads proxy specific configuration (#58307)
      Adding tests for changes to virtual function for netmiko module.  Adding tests for netmiko proxy minion module.
      Adding changelog.
      Running pre-commit bits manually.
      Running pre-commit bits manually.
      Running pre-commit bits manually.
      Running pre-commit bits manually.
      Running pre-commit bits manually.
      Another round of pre-commit.
      Running pre-commit bits manually.
      Running pre-commit bits manually again.
      Running pre-commit bits manually.
      Adding tests for changes to salt.states.win_system.workgroup.
      Adding tests for etcd SDB changes.
      Rename test_etcd.py to test_etcd_db.py
      Rename test_etcd.py to test_etcd_db.py
      Fixing a use case when multiple inotify beacons are defined but when notifications are fired the configuration fron the first beacon are used.
      Adding changelog.
      Adding a util function to remove hidden (options starting with underscore) from the beacon configuration.  This is used when the beacons loop through the configuration, eg. status beacon, and expect certain options.
      Adding missing file.
      Fixing failing tests.
      This one should be beacon_name in the ret instead of _beacon_name which goes in the configuration.

Gijs Peskens (1):
      Fix #57602

Glynn Forrest (4):
      Add failing test for file attributes in x509.certificate_managed
      Always run file.managed on x509 certificates
      Don't show the certificate as changed if the file.managed call fails
      Show changes from file.managed in test=True output

Henri Wahl (2):
      Avoid gaierror: [Errno -9] Address family for hostname not supported
      Use socket.getaddrinfo

Hilberding, Rob (1):
      updated doc string

James Howe (4):
      Based on PR #52362
      Based of PR #52362
      Six thousand, not six million
      Fix typo from typo fix

Jarrod Funnell (3):
      Fix name returned by list_vdirs
      Lint and format changed code
      Attempt to add tests

Jason Traub (5):
      revert others changes
      pre-commit suggested changes
      #58412 dont overwrite kwargs
      saltstack/salt#58412 fix first commit and add testing
      saltstack/salt#58412 mock prepare_connection since it depends on netmiko

Jasper Lievisse Adriaanse (11):
      Stop using deprecated cgi.escape
      pre-commit fixes
      Add initial tests
      add tests for html.escape
      Add tests to verify strict permissions on private keys
      Set mode of key files to 0600 instead of leaving them world readable
      Apply pre-commit fixes
      Sync OpenBSD installation documentation with reality
      Fix versionadded in style guide
      Drop manpage modification.
      IRC logs are no longer available.

Jean-Yves NOLEN (1):
      Filterwarning overide previously defined filters ISSUE:57582

Jeremy Willden (1):
      Corrected a section title (#58151)

Joe Eacott (11):
      Add password arg to cmd state and tests
      Whoops this is important to add
      Added versionadded
      fix docs
      Fix test_mode and add tests for pip state
      Fix test tmp dir name
      Add if else to address when more than one package is present
      remove duplicate line
      blacken files
      Add winrepo
      Remove six from modules/winrepo.py

John Nielsen (1):
      Fix etcd with sdb (fixes #52268)

Jorge Schrauwen (2):
      [Fix] #57714 virtual grain should work on illumos
      Test illumos virtual == zone grains paths

Justin Findlay (3):
      58033 `file.read` return binary data in binary mode
      utils.jinja DRY import parsing
      utils.jinja Add profile block and profiling of import_* jinja calls

Ken Crowell (16):
      Link salt-ssh python requirement to install docs
      s/enpoint/endpoint/g
      Run precommit on changed files from parent
      Add timeout kwarg docs for service.running and service.dead
      Clear up requirements for salt-api+ssh
      Add ssh_options to roster docs
      Reinstate some skipped tests
      Save local client SaltAPIHandler::job_not_running
      Address teardown warning in test_rest_tornado
      Add test for rest_tornado exception
      Run pre-commit hooks on changes
      Move changelog for #58311 to changelog/
      Remove old documented pending reboot key
      Ignore ValueError when loading pickled s3 cache
      Make gpg.encrypt examples work
      Run pre-commit

Kirill Goncharov (1):
      Add usage example to documentation of file.copy state

Lukas Raska (4):
      Bump timelib to 0.2.5 to fix Mac OSX build issues
      Fix UnboundLocalError when address cannot be resolved in win_network.connect
      Use autospec and side_effect directly
      Fix win_pdh.get_counters failing when no data are available

Marc Schiffbauer (4):
      fix virtual grain detection with 'virt-what'
      fix virtual grain detection with 'virt-what'
      add test for PR#57263
      fix test in tests/unit/grains/test_core.py

Marco Cusano (5):
      The bug that doesn't allow use to source the os version in Centos 7 from lsb_distrib_release affects Centos 8 as well.
      Changing grains/tests_core.py to check for correct osrelease / osrelease_info output on Debian
      adding centos 8 os grains test
      changing linux_distribution function to private
      unit/grains/test_core.py update linux_distribution to private

Marek Marczykowski-Górecki (3):
      pkg: report stdout when stderr is redirected to stdout
      Add test for yumpkg.install error reporting
      yumpkg: drop six usage, reformat file

Marek Skrobacki (1):
      iptables: document 'chain' kwarg for 'flush' state

Mark Ferrell (11):
      fix: minor clarification in the grains docs
      Revert "Make def private"
      fix: remove pack_dunder usage
      fix: pre-commit cleanups
      fix: remove pack_dunder in remaining tree
      fix: changes made by pre-commit scripts
      feat: allow querying for the default VPC
      fix: cleanup changes made by pre-commit scripts
      fix: enable Boto unit tests
      fix: boto_vpc subnet tests missing vpc_id
      fix: changes introduced by pre-commit scripts

Markus (1):
      Rename _schedule.conf on YAML parse error (#58179)

Markus Kramer (9):
      Jenkins Lint
      document the codepage parameter in run()
      Removed typo and reworded
      Fixing comment
      Rename chcp_code to windows_codepage
      Remove trailing whitespace
      No try/except in test_chcp
      isort_black_code_Page_for_shell
      Rename chcp.py to win_chcp.py

Martin Overgaard Hansen (2):
      Corrected example typo
      Corrected typo in example

Mathieu Parent (10):
      Add tests for GPG cache
      Use atomic open to write cache
      test_git_pillar: passphrase-protected actually works on current Debian OS family
      On start, update git_pillar on first loop, withour waiting git_pillar_update_interval
      Add pre-commit suggestions
      Allow to pass arguments to fileserver.update runner
      Add pre-commit suggestions
      Fix pylint
      Apply "Remove import comments"
      Allow to override git_pillar_base per-remote (Port #51640 to master) (#57288)

Matt Phillips (1):
      saltnado: don't use gather_job_timeout as a timeout signal in job_not_running

Matthew Garrett (1):
      Updated smtp documentation to include directions for sending to multiple recipients.  Feature was introduced in 2015.8

Max Arnold (4):
      Fix deprecation note for old module.run syntax
      Replace Sodium with 3001 for new master niceness settings
      Sysctl ignore flag was added in Sodium (not Neon)
      Fix incorrect versionadded tag syntax

Megan Wilhite (28):
      Keep support for both authentication configurations in kubernetes
      fix pre-commit
      fix pre-commit
      fix pre-commit
      fix pre-commit
      remove include_localhost kwarg from connected_ids
      Add connected_ids test
      fix pre-commit
      run pre-commit
      run pre-commit: remove import comments
      fix pre-commit
      fix pytest ssh tests
      Update doc about python version support
      Revert "override get_new_ioloop for TestEventListener"
      Add global lazyloader test
      Run pre-commit
      Run pre-commit
      run pre-commit
      Run pre-commit
      Run pre-commit
      Run pre-commit
      pre-commit: remove comments
      run pre-commit
      Add changelog
      Pass in protocol to ssl context
      Fix pytest ssh tests
      Run pre-commit
      Remove flaky decorator

Michael "M3" Lasevich (4):
      Fix bug introduced in #58238 feature flag implementation
      Typos Identified in #58238
      Fix inconsistent name of the feature flag
      Adding unit test for feature flag selection

Michael Birtwell (3):
      Fix caching pillar/grains which contain bytes
      Apply changes from pre-commit to fix_caching_bytes
      Fix show error report from salt.function

Michael Mulqueen (2):
      Improve robustness for invalid dmidecode characters and add test.
      Fix coding style (blacken) for DMI fix.

Mike Place (1):
      Merge pull request #50527 from bloomberg/sanitize

Nate Bohman (2):
      Adding Unit Tests and Fixing debian_eth.jinja
      Adding accept_ra 2 option to modules.debian_ip

Nicholas Hughes (3):
      Port PR #48989 to master (#56691)
      cherrypy: fix handling of raw application/x-www-form-urlencoded traffic (#54901)
      Adding nftables functionality for use in EL8 (#56259)

Nicole Thomas (3):
      Merge pull request #50449 from rmustard/state-support-chocolatey-timeout
      Merge pull request #49949 from rares-pop/dev/iepopr/add-saltapi-in-windows-installer
      Merge pull request #49901 from twangboy/fix_startup_issues

Nitin Kumar (5):
      handle config load error when cache is not avialable for first time
      add unit test for bug fix
      feedback from saltstack wrt to dirs
      fix ut corresponding to code changes in lib
      fix english

Pablo Suárez Hernández (19):
      Add missing 'fun' for returns from wfunc executions
      Add unit test for checking missing fun in SSH events
      Avoid HAS_DOCKER true if import messes with salt.utils.docker
      Move checks into _is_docker_module function
      Add initial unit tests for swarm module
      Update salt/modules/swarm.py
      Pass module name to hasattr function
      Add changes suggested by pre-commit
      ansiblegate: take care of failed, skipped and unreachable tasks
      Add code suggestions made by pre-commit
      Add 'retcode' from ansible-playbook execution to the returned data
      Add pre-commit suggestions
      Add new unit tests for ansible execution module
      Always add retcode to ansible.playbooks output
      Adjust ansible.playbooks output comment properly
      Add unit tests for ansible.playbooks state
      Remove redundant code importing pytest
      Move mocking inside the test functions
      Move remaining mock inside the test function

Pedro Algarvio (194):
      Resolve paths when checking from filenames functionality.
      Fix sorting issues on `x509.certificate_managed` triggering unnecessary changes
      Remove Sodium related deprecation warnings
      Don't fail when `--from-filenames` is passed `salt/__init__.py`
      Revert "Add ShiftLeft Scan to the pipeline"
      Pass the config directory CLI argument when calling salt-cloud
      Always pass `config_dif`
      Drop six usage
      Run pyupgrade against file
      Fix requirements
      Remove non Py3 requirements
      Remove SmartOS esky requirements files
      Comment out the watchdog requirement.
      Bump psutil to 5.6.7. The 5.6.6 version has a vulnerability.
      Bump PyYAML version, 5.2.1 has a vulnerability
      Fix static requirements
      Add pytest helpers to automate unit testing loader mocking
      Actually, don't namespace the functions
      Add helper function to build a namespaced dictionary of a salt loader module
      Migrate `tests/unit/beacons/test_sensehat.py` to PyTest
      Migrate `tests/unit/beacons/test_status.py` to PyTest
      Migrate `tests/unit/modules/test_alternatives.py` to PyTest
      Migrate `tests/unit/modules/test_ansiblegate.py` to PyTest
      Migrate `tests/unit/modules/test_archive.py` to PyTest
      Migrate `tests/unit/modules/test_azurearm_dns.py` to PyTest
      Migrate `tests/unit/states/test_alternatives.py` to PyTest
      Update docs to reflect how to write the new unit tests
      Properly patch the `__proxy__` dictionary
      Reuse `LoaderModuleMock` with unittest
      Death to globals!
      Assert against what was actually mocked!
      Start upgrading codebase to Py3 for every changed file
      Teach coverage a bit more about salt paths.
      Add `napalm` to testing static requirements
      Death to globals!
      Do not mess with salt dunders directly!
      Don't mock at the global module level scope!
      We don't need the full state tree
      Use a test class specific temp directory. Make sure to clean up after each test
      Remove `napalm` from the windows static requirements
      Add more insight into failures
      Fix duplicate `console_scripts` entry under windows
      Add `.copy()` method to the other immutable classes
      Death to globals!
      No global scope prep work!
      No mocks at the global module scope!
      Freeze napalm test objects
      Use `pytestmark` instead
      Move pytest tests to the right path
      Revert the changes needed to support `runtests.py`
      Pass along the log server settings to `salt_factories_config` fixture
      Add new salt-factories compatability layer
      Switch virt integration tests to PyTest
      Extend the salt-factories compatability layer
      We should not mess with `module`, `class` or `function` scoped fixtures
      Use `pathlib` to fix the thin unit tests under windows
      Fix expeced result on windows
      This test module does not target linux service alone
      The error is now different
      Show local variables on test failures
      Move `get_virtualenv_binary_path` to `tests.support.helpers`
      There are other sleeps involved when running under pytest
      We can't just change module attributes while testing. Use mock.patch.
      Update salt-factories compat to latest
      Never use setuptools==50.0.0
      Bump black to version 20.8b1
      Never use setuptools==50.0.0. Followup to 87c94b3490
      Revert "Bump black to version 20.8b1"
      Don't use the same service, we might get throttled and the test fails.
      Don't install setuptools >= 50.0.0 until they release something useful
      Bump pytest-salt-factories to 0.11.x
      Import the pytest fixtures on the "main" conftest.py
      Fix windows unit test white listing under PyTest
      Never mix unittest and pytest tests
      Less intrusive control over package scoped fixtures
      Drop our custom mark evaluator
      Skip tests which did not run before migrating to PyTest
      Bump PyTest to 6.0.1
      Bump pytest-salt-factories to 0.11.4
      The virt minions should be using the salt master transport
      Add skip decorator to use in tests that need to run under PyTest
      Use PyTest fixtures for the Git Pillar tests
      Bump pytest-salt-factories to 0.92.x
      Migrate the test valid docs integration test to pytest
      Ignore missing paths and pytest tests
      Don't write bytecode inside the container
      Be sure to set a minion id in temp minion configs
      Migrate proxy tests to PyTest
      Untangle `test/integration/shell/test_proxy.py`
      Untangle `test/integration/shell/test_runner.py`
      Untangle `test/integration/shell/test_cp.py`
      Untangle `test/integration/shell/test_call.py`
      Untangle `test/integration/shell/test_key.py`
      Untangle `test/integration/shell/test_master.py`
      Untangle `test/integration/shell/test_minion.py`
      Untangle `test/integration/shell/test_syndic.py`
      Untangle `test/integration/shell/test_saltcli.py`
      This code is no longer used. Nuke it.
      Untangle `test/integration/shell/test_auth.py`
      We need to `set_path` for macOS, see #56627 for more info
      Switch to `pathlib` and use `change_cwd` instead
      Fix the tests file mapping
      We need to set `RUNTIME_VARS.PYTEST_SESSION` sooner
      Tests calling `wait_for_all_jobs` need to have the sub_minion running
      Bump PyTest requirement to 6.0.2
      Skip tests which randomly fail under Py3.5
      Remove duplicate and wrong test case
      Bring more data into the test failure
      Don't run any after fork or finalize methods for the test
      Fix `integration.ssh.test_grains.SSHGrainsTest.test_grains_items` on FreeBSD
      Remove duplicate test
      Improve proxy minion detection.
      Fail gracefully in case of failure to get the AutoUpdate object
      Fix static requirements (pre-commit)
      Update pre-commit from nox-py2 to nox
      Automatically remove import comments on files.
      Bump to six==1.15.0 to avoid failures with the pre-commit checks
      We don't really need to depend on the `request` fixture
      Always reset the function globals
      Only patch functions which would be loaded by Salt's LazyLoader
      No need to patch `__virtual__`
      Remove debug print
      Revert "fix vmware for python 3.4.2 in salt.utils.vmware"
      Fix django module unit tests
      Fix `fqdn` grains unit tests
      Just make sure private functions don't have access to salt dunders
      The loader puzzles me til this day....
      Fix `tests/unit/states/test_postgres.py` tests
      Remove test from windows whitelist
      The nox session `invoke_pre_commit` should not create a virtualenv
      The nox session `invoke_pre_commit` should not create a virtualenv
      Fix `test_json_out_indent` on windows.
      Skip tests not applicable to windows
      Fix `test_issue_5449_report_actual_file_roots_in_pillar` under windows and pytest
      Fix `test_issue_5951_actual_file_roots_in_opts` under pytest and windows
      Remove test from windows whitelist
      Skip test on windows which was being skipped before pytest
      :facepalm: These run against the dummy proxy!
      Proxy tests can run on all platforms
      Issue a warning when `loader_mock` get's passed `request` as an argument
      Bump salt-pylint requirement to v2020.9.28
      Bump to PyTest >= 6.1.0
      Fix PyTest's tests integration files copy
      Generated JID's are now UTC by default
      This test is sensible to dictionary ordering
      Bump pytest-salt-factories to 0.93.x
      Fix `tests.pytests.unit.modules.test_ini_manage.test_section_req` on Windows
      Fix static requirements again
      Fix format keys
      Ohlo is long gone
      Fix path in license
      Salt no longer supports IOFLO
      Move CI static requirements to it's own subdirectory
      Salt is not Py2 compatible since Sodium
      Add packaging static requirements
      Use the locked packaging requirements
      Rework static requirements. Darwin and Windows packaging are now also static.
      Allow choosing static vs base requirements.
      Update OSX build script to point to the right static requirements file
      Update Windows build script to point to the right static requirements file
      Upgrade pip on the created virtualenv's
      Strip out any pip flags when parsing requirements.
      Remove security advisor now that we depend on PyCryptodomex
      Fix pre-commit pip-tools-compile regexes
      Disable CI concurrency
      Clean up sys.modules when the loader is GC'ed
      Switch to the remove-import-headers pre-commit hook
      Fix pre-commit on master branch
      Remove un-necessary config file
      Fix `unit.test_proxy_minion.ProxyMinionTestCase.test_proxy_config_default_include`
      PyTest now uses argparse.
      F-Strings are Py3.6 only. Sadly, We still have platforms on Py3.5.
      Don't expect bash to be the default shell
      Fix and simplify `tests/pytests/functional/modules/test_opkg.py`
      `request` is not longer required
      Only set the code page for the command to run. Reset it afterwards.
      Try command chaining again
      Remove six usage
      Use `win32console` instead
      Drop Py2 and six on salt/utils/parsers.py
      Set the codepage on windows at import time of `salt/utils/parsers.py`
      Revert "Set the codepage on windows at import time of `salt/utils/parsers.py`"
      Skip tests depending on the `ssl_webserver` fixture if on Py < 3.5.3
      Fix static requirements
      Even more complete static requirements regexes
      Start checking rst files at pre-commit level with `rstcheck`
      Upgrade `pytz` requirement to `2020.1`
      Linux and FreeBSD packaging requirements now include CherryPy.
      Add `psutil` to the packaging static requirements for Linux and FreeBSD
      Add some more packaging requirements for Linux and FreeBSD
      Move changelog entries to the correct location
      Add hook to check for badly named changelog entries
      Fix mispacled and wrongly named changelog entries
      Downgrade to pycparser==2.17 to un-break tiamat builds

Proskurin Kirill (4):
      Added strcit argument to sdb.get
      rebased + pre-commit stuff
      Fixed salt.runner test mode output
      rebased + pre-commit stuff

Radostin Stoyanov (32):
      virt: Update dependencies
      virt: Remove unused imports
      integration/test_virt: Assert 'profiles' type
      virt: Handle no available hypervisors
      virt: Refactor get_profiles() and integration tests
      Add virt.all_capabilities integration test
      Add virt.capabilities integration test
      virt: Don't expose check_remote and download_remote
      Add virt.cpu_baseline integration test
      Add virt freecpu/freemem integration test
      Add virt full_info/node_info integration tests
      tests: Add virt minion integration targets
      tests: Reuse code for starting libvirt+minion
      tests: Reuse code starting salt daemon
      tests: Add virt integration test define_xml_path
      tests: Add virt.migrate integration test
      tests: Update virt-minion container image
      tests: Check define_xml_path output type
      virt: Use libvirt-python for domain migration
      Add changelog for #57431
      Add changelog for #57947
      tests: Set tls/tcp ports for virt containers
      tests: virt.migrate over TLS and TCP
      virt: Add support for offline migration
      virt: Add support for migration bandwidth limit
      virt.migrate: Add live/persistent/undefinesource options
      virt.migrate: Add support for max_downtime
      virt.migrate: Add support for parallel connections
      virt.migrate: Add support for compression
      virt.migrate: Initial support for post-copy migration
      Resolve formatting issues
      virt: Inline copy_storage doc string

Ryan Addessi (raddessi) (5):
      Fixed a messed up rebase
      Fixed some issues Pedro noticed
      Removed unused variable in test
      Moves states test to proper location
      Added some fixes from review

Sage the Rage (2):
      Update issue templates docs
      move suggested fix

Sam SIU (1):
      [#56901] network.managed state failed to bring down lo ip alias

ScriptAutomate (22):
      Add minion_id_lowercase details to minion conf
      Security docs updates with newer resource links
      Updating documents to reference new archive locations
      Fixed minor formatting
      Removing Python 2 references on latest minion
      Move py3 / py2 paragraph above archive links
      Expand supported OS in suse
      Updating Windows OS tested versions
      Updated windows system testing targets
      Various install page version updates
      Adding need for review of installation docs
      Archive repo cmd workaround for debian/ubuntu/rhel
      Auto-changes made to conf.py by pre-commit
      Add refresh arg to update() docs; pre-commit fixes
      Better search / SEO experience for finding docs
      Added some more resources
      Rearrange word placement in FreeBSD doc
      Italicize quote
      Properly reference yaml.org
      Updating to v2.0 of contributor covenant
      Refresh README; add SECURITY; update logos
      Fix rst formatting

Sebastian Marsching (2):
      Fix #57189.
      Add test case for #57189.

Serge Dubrouski (1):
      Do not fallback to 127.0.0.1 for un-resolvable masters in failover mode (#57699)

Shaun Maher (1):
      Documentation: Update incorrect example code in x509.py

Shea Craig (10):
      Include Big Sur vers "11" in mac_softwareupdate modern pattern condition
      Add test case for Big Sur.
      Remove legacy python cruft and blacken.
      Fix tests legacy python cruft.
      Use `osrelease_info` grain for major version number.
      Add changelog entry.
      On macOS check if git is a stub or not before importing gitpython.
      Only check for dev tools git stub if `which git` is the system git.
      Add changelog entry.
      Add tests for git_is_stub.

Spenceation (1):
      -Fixed LINT issues.

Steffen Kockel (4):
      states/postgres_initdb: Remove invalid kwarg allow_group_access
      states/postgres_initdb: Rename data_checksums keyword to checksums
      states/postgres_initdb: Remove invalid kwarg wal_segsize
      states/postgres_initdb: Add waldir kwarg to docs

Steve Groesz (1):
      Do not strip trailing forward slash from repo URI

TGuimbert (3):
      Added list_sources
      Added source_added
      Add changelog

Thomas Bernard (1):
      Fix the incrontab module to operate when the user is not root

Tyler (2):
      Update 55024.fixed
      updated add_mock and del_mock return values

Tyler Bowers (8):
      added retcode return support
      use retcode to avoid locale issues
      assert_called_once_with includes retcode=True
      added changelog
      fixed bad whitespace
      clarified retcode param in docstring
      splitted a few asserts across multiple lines
      modified overlooked add_mock and del_mock ret vals

Tyler Johnson (3):
      added idem exec and state modules
      States can have sub state returns
      passing pre-commit

Vaarlion (1):
      Force version type to string in deb_postgres module (#58299)

Varjitt Jeeva (1):
      Fix Docs: Salt 3000 onlyif targeting with grains cannot have a space in function query

Wayne Werner (18):
      Run boto_route53 test on Python 3.7+
      Fix imports
      Add runas to updgrade command
      Allow user in version command
      Provide user to version command as well
      Added changelog
      Added changelog files
      Fix for changelog project dir
      Updated changelog
      Add tests for nilrt_ip._load_config
      Fix issue in nilrt_ip
      Remove python2-isms
      Add changelog entry
      Add tests for salt.runner test mode output
      Add test for non-grant_option "ALL" privs
      Add changelog
      Add tests for opkg and restartcheck changes
      Ported #51218 to master

Wesley Whetstone (43):
      add fix for when launchctl bootout returns a non zero retcode on some services
      add tests for skipping ignoring a retcode on launchctl bootout
      add a test to make sure we still fail with a retcode of 36 on non bootout cmds
      add support for Big Sur when searching for libcrypto
      run precommit
      remove mac_utils version in favor of in line check, and add other recommendations
      add changelog
      remove str cast on macOS and add comment for windows str cast
      remove windows str cast
      remove old windows string comment
      remove py2 in macOS build script, fix python build using compiled openssl, move pyobjc back in to req.txt
      remove CFLAGS var and add an option to skip the --enable-optimizations flag of python for a faster test build
      fix arg documentation and assignments
      move pyobjc back to standalone and update to 6.2
      add pyobjc back to setup.py
      fix readme layout and update doc strings
      update pyobjc 6.2.2, this is to support macOS Big Sur
      first pass at proper enable/disable checks
      add tests
      add tests for mac_service changes
      add additional tests and service changes
      fix comment
      add a more strict check on PID to avoid false positives
      move to most tests to pytests
      move mac_service tests to pytest
      add changelog
      fix grammar in changelog
      fix mac_service.loaded CLI example
      fix mac_service integration tests
      update failing tests
      pyupgrade
      pass precommit
      use global_path
      need the w for write
      pre-commit all files
      pyupgrade mac_service
      blacken service state after pyupgrade
      precommit test service
      fix service test
      remove breakpoint
      pyupgrade service int state
      Improve macOS service naming support (#57646)
      Fix mac_service failures on Big Sur. (#58144)

alxwr (1):
      Update error message in states.x509.certificate_managed

ch3ll (12):
      Do not lookup reverse dns with salt-ssh
      skip tests if ssh binary not found
      remove encoding kwarg for both pack/unpack msgpack
      use tmpdir pytest fixture
      do not del roster_file from opts for ssh netapi
      migrate msgpack kwargs tests to pytest
      Use salt.utils to get bower path
      Add verify_ssl to file.managed state
      Create file if doesnt exist ini.options_present
      Do not allow python2 to be added to salt-ssh tar
      override get_new_ioloop for TestEventListener
      add clean kwarg to doc builds

cmcmarrow (54):
      clean up minion start
      remove a print
      fix window pid 5 and remvoe tests
      fix tests
      fix tests for win
      small fix
      no tests but fix
      add it some tests
      fix typo
      full patch
      fix salt_api
      rename fuc
      add test
      clean up
      add utf-8
      clean up process alittle
      fix mock loop
      add back old pidfiles
      fix salt api
      stop minion from overwriting pidfile
      let_people_change_the_code_page
      clean up code page
      add back response
      add tests
      add back 65001
      adds webconfig tests
      fix zmq hang
      try late import
      move force_close
      fix pre-commit
      fix pre
      update broke pre
      hot fix
      fix __init__
      fix __init__
      fix zeromq
      add log
      update pycryptodome
      run pre again
      dep jid
      dep jid add log and test
      dep_async_from_mandrill
      dep_async_from_mandrill
      dep_describe_route_table
      dep_describe_route_table
      dep_describe_route_table
      dep cake
      add log
      dep zfs soduim warns
      dep_zfs_soduim_warns
      remove_show_ipv4
      remove show ipv4
      update docs
      clean tests

ellisbenjamin (1):
      adding linode4 provider.

firefly (2):
      virt: add VM memory tunning support
      avoid comparing string with integer

gqlo (2):
      fix pre-commit failure
      fix regression tests failure

krionbsd (39):
      Fix typo by adding device_write_iops in documentation.
      Skip 2 tests on FreeBSD.
      Fix test_acme on FreeBSD
      Skip blkid test on FreeBSD.
      Skip tests for Linux ACLs on FreeBSD
      Fix failing test on FreeBSD
      Fix broken test and disable another (temporary) on FreeBSD
      Cover pkgng module with new tests.
      Pass real arguments to ListPackages() instead of **kwargs, this might
      Use OrderedDict to preserve the order.
      Add some new tests and fix 1 wrong test name.
      Add 2 second timeout on DNS socket check
      [merge jam] port 52856
      Disable tests on FreeBSD
      brush up the skipif message
      Fix broken slow and destructive tests on FreeBSD
      Disable locale related test on FreeBSD
      Disable docker integration states tests on FreeBSD
      Fix broken cron slow test on FreeBSD
      Skip test which is incompatible with FreeBSD
      Use server_channel.pub_close() instead of server_channel.close()
      Drop pyzmq to 18.0.1 on py3.8
      Restore pyzmq ver. and skip some tests on Linux
      Skip test on FreeBSD as there's limited inotify/watchdog support on it
      Fix broken slow test on FreeBSD
      Skip beacon test on FreeBSD
      Fix broken slow test on FreeBSD
      Fix broken slowtest on FreeBSD
      [merge jam] port 53224
      Add Welcome bot
      Add URLs
      Add URL for CoC
      Fix formatting
      Fix typo
      Update docutils to 0.16
      Downgrade docutils to 0.15.2 to unbreak pre-commit
      Update pytest to 6.1.1 bugfix release
      Update botocore to the latest 1.16.26 release
      Cleanup for contacts

lomeroe (6):
      Update dpkg_lowpkg to handle deb files that have spaces in `dpkg -I` output (#54740)
      update sc_removal_lookup to use string values as keys
      correct tested value
      Correct issue with reading some deleted items from registry.pol
      add special value regex in _checkAllAdmxPolicies helper function
      properly cast delvals_regex to bytes for search

mlasevich (1):
      Cleanup calculation of template sls/tpl context (#58238)

nee2c (2):
      pylint update
      Fixed issue #53887

nicholasmhughes (11):
      fixes #57795 adds require docs to cloud maps
      port #49063 to master
      refactor to use config func and loop over key combos
      add tests for get_configured_provider
      add get_conn test for azurearm
      49063 changelog
      fixes #57802 broken block_device_mapping type checks
      update changelog for 57802
      fix docstring
      fix docstring
      complying with new tests that were recently added

nico (4):
      Added additional unit test to verify certname variable is utilised
      Fixed comments that mention ComminName instead of certname
      Added additional unit tests to verify certname variable is utilised
      Fixed side_effects for both assert that are tested

nko321 (2):
      Update cloud_controller.rst
      Update cloud_controller.rst

pbeetham (1):
      Fixed regex in 'save_config' to avoid issue if device name is md1, PA… (#55876)

piterpunk (53):
      Fix grains/disks.py to show only the real disks
      Added unit tests for disks._linux_disks
      Added autospec=True to test_disks.py unit test
      Added the Changelog entry for fix 57612
      Changes the 'SSDs' grain name to 'ssds'
      Allow resize in lvm.lv_present state
      Avoid "Unknown Key" error reading lv_info in lvm.lv_present
      Added unit tests for lvm.lv_present state
      Use os.getpid() to filter results in status.pid
      Changes test_status_pid to compare full PID list
      Revert "Changes test_status_pid to compare full PID list"
      Added unit tests for status.pid
      Added default answers to lvm.linux_lvm questions
      Cleaning the exceptions trackback in linux_lvm.py
      Cleaning the exceptions trackback in linux_lvm II
      Added LVM pvresize and lvextend to linux_lvm
      Many changes in LVM state and module
      Added changelog entries
      Added "lvm" grain to list the LVM volumes
      Added salt.grains.lvm to index.rst
      Added unit tests for lvm grains
      Remove Py2 support from grains/lvm.py
      Dropped Py2 support from test_lvm.py
      Added mkpart unit tests and removed mkpartfs
      Added changelog entry
      Re-added mkpartfs to not break compatibility
      Added device validation before executing mkpart
      Initial support to manage services in Slackware
      Added unit tests to slackware_service.py module
      Added Changelog entry for #58206
      Fixed slackware_service's enable and disable tests
      Fixed underlines in RST file
      Migrated tests to PyTest and added release version
      Many changes in slackware_service unit tests
      Added changelog entry
      Added tests Proxmox connection custom port
      Change get_repo in yumpkg.py to expect repo param
      Added get_repo unit tests to test_yumpkg.py
      Adjusted to pass the updated requirements
      Removed import comments
      Added parameter fs_mount to mount.fstab_present state
      Changed mount.mount module to accept only the mount point.
      Mount the added filesystem in mount.fstab_present when mount=true
      Updated mount._convert_to to use blkid directly.
      Revert "Updated mount._convert_to to use blkid directly."
      Changed decorators in salt/modules/disk.py from depends to path.which
      Check "mount" when run mount.fstab_present with test=True
      Update unit/states/test_mount.py with mount parameter
      mount.mounted puts ordered options on fstab
      Re-added the sort() for mounted filesystems
      Added changelog entry for fix 57520
      Added option ordering test for mount.mounted
      Fixed test to use variable instead of fixed string

psyer (7):
      fix msgpack max_buffer_size being to low in ver >= 0.6 and < 1.0
      Run code through black
      fix trailing whitespace for the linter
      fix msgpack max_buffer_size being to low in ver >= 0.6 and < 1.0
      Run code through black
      fix trailing whitespace for the linter
      run precommit hooks on code to get black to fix file

rallytime (1):
      Update reactor docs with small formatting fixes

sammy (5):
      [55949] Handle Docker API error when swarm_init is called when there is already an existing swarm
      [55949] Add changelog
      [55949] Fix changelog naming
      [55949] pre-commit
      [55949] pre-commit

sindhukothe (1):
      Fix for #55652 - Proc file naming (#55653)

sizgiyaev (1):
      Added support of GRANTS with per column privileges to MYSQL module (#55980)

spenceation (3):
      -Adjusted CIMC proxy module to properly handle HTTP error codes and
      Added DRY changes.
      Changed logging on response validation to error.

tguimbert (7):
      Added list_sources test
      Add source_added tests
      Fixing lint and variable name
      Correct formating errors
      Correct more formating errors
      Corrected wrong order in imports
      Change a function name to source_present

twangboy (107):
      Redact password in container settings states
      Use container settings
      Fix typo
      Use dict for expected result
      Fix return dict
      Fix changes
      Add test for failure
      Fix return with failures
      Fix expected changes
      Fix expected comment
      black
      Add changelog
      Remove KB from build scripts
      Unzip UCRT to python root
      Make sure bin directory is present
      Add NSISPluginsDirA and NSISPluginsDirU
      Fix plugins path
      Add trailing newline
      Add changelog
      Add winrepo_fallback option
      Update docs for winrepo
      Fix docs
      Add changelog
      Fix docs issue
      Fix duplicate label
      Use jinja lexer
      Further docs clarifications
      Add review suggestions
      Add missing }
      Fix some issues with EnVar build_env
      Fix build scripts for OSX
      Add missed dependency
      Update build scripts
      Add changelog
      Fix changelog
      Add changelog
      Fix docs
      Fix pending_reboot false positive
      Fix failing tests
      black
      Drop py3 support (pre-commit)
      Update docs and comments
      black
      Black
      Fix lint error
      Remove more py2 code
      Use dir on Windows
      Add unit test
      Add changelog
      fix pre-commit
      Fix isort and pyupgrade
      Fix formatting
      Fix pre-commit
      Fix some lint
      Black
      Simplify chained comparison
      Fix pre-commit isort
      Fix pre-commit isort
      Fix pip/setuptools upgrade
      Fix pre-commit isort and comments
      Fix pre-commit isort
      Add restart delay when minion fails to start
      Squash... add tests
      Add changelog
      Fix pre-commit
      Fix one more pre-commit issue
      Add pre-flight checks for win_wua module
      Add changelog
      Black some files
      Fix some lint
      Fix pre-commit issues
      Fix one more pre-commit item
      Add Support URL
      Add comment with URL to iUpdate properties
      Add tests for win_wua __virtual__ function
      Add unit tests for new service util
      Fix some lint
      Fix pre-commit errors (black)
      Fix pre-commit (black)
      Add some more tests for win_wua state
      Make it test_mode
      Black test_win_wua
      Check for dataclasses
      fix black
      Fix import
      Skip if less than Py3.6
      Use namedtuples instead of dataclasses
      Fix pre-commit comments
      Import order
      Fix pre-commit isort
      Add a test
      Add changelog
      Fix pre-commit black/py2
      Black
      Fix pre-commit py2
      Fix pre-commit comments
      Fix some lint
      Use format instead of f-strings for py3.5 compat
      Black
      Fix pre-commit black and isort
      Fix some docs
      Update docs for the lgpo state module
      Add changelog
      Remove py2 support
      Fix some black
      Fix pre-commit isort and comments
      Fix changelog, put it in the right directory

tyl0re (1):
      Fixed Bug LVM has no Parttion Type.

wb529kq (1):
      Update win_task.py

x70b1 (1):
      Port 51998 to master

xeacott (2):
      add missing import back missed the port
      Add changelog file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants