Unclear error message for assertSame()

[dimo414]

The error message from assertSame() does not make it clear the failure was that the objects aren't identical. Consider assertSame("foo", new String("foo")) - this fails with java.lang.AssertionError: expected [foo] but found [foo]. Granted, the stack trace indicates the error came from assertSame(), but a quick glance at the error text is confusing - didn't it get what it expected?

I'd suggest adding an assertEquals() call inside assertSame() after the equality check, and if that passes (meaning they're equal but not identical) failing with a different message, like expected [foo] but found equivalent but not same [foo].

Less important, but the assertNotSame() error message contains both expected and actual, which are known at that time to be the same object. It seems somewhat unhelpful to include the same object twice in the error.

[FibreFoX]

Its true that the message is confusing, but i would not suggest to add assertEquals()-calls, it may create unwanted performance-loss (in case the equals-methods are performance-heavy).
Another thing is, when calling assertSame() i dont want to check if the both subjects are equal.

:) but thats just my view of this point

[dimo414]

I was only suggesting doing an equals() check after the == check has failed, which I don't think would impact performance very much. My thinking is to have a different error message for unequal objects and non-identical objects. When assertSame() fails it would be helpful to know if it's because the objects are outright unequal, or simply not the same object, and the former check and error message is provided out of the box by assertEquals().