Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flags: use time.Duration in duration flags #803

Open
jsign opened this issue Mar 16, 2021 · 0 comments
Open

flags: use time.Duration in duration flags #803

jsign opened this issue Mar 16, 2021 · 0 comments

Comments

@jsign
Copy link
Contributor

jsign commented Mar 16, 2021

We currently have some arbitrary magnitude durations seconds/minutes as Int64 in flag/envs

Switch to time.Duration since it's much clearer and the user can specify them with 10m or 10h. This avoids confusion about the right magnitude: seconds or minutes?

This is a breaking change, since the operators should fix whatever flag/env that they might be overridden, so it would be good to batch into some planned major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant