Add SaveAllCommand #238
Merged
Add SaveAllCommand #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (persistedDocument == null) continue; | ||
|
|
||
| // skip if the file is new | ||
| if (!persistedDocument.IsNew) |
|
For my edification, is "what" (this) what Visual Studio does? |
|
@tgjones Actually the SaveAll command in VS saves all edited (IsDirty) documents and it shows "Save Prompt" for new documents. However, I think "skip new document" is enough, if users know it. |
|
Yes, I believe that's correct, including project changes. |
| { | ||
| var tasks = new List<Task<Tuple<IPersistedDocument, bool>>>(); | ||
|
|
||
| foreach (var document in _shell.Documents) |
There was a problem hiding this comment.
This can be changed to this:
foreach (var document in _shell.Documents.OfType<IPersistedDocument>().Where(x => !x.IsNew))
diluculo
force-pushed
the
215_SaveAllCommand
branch
from
ffd86e6 to
aadeb81
Compare
|
LGTM - @diluculo is this ready to merge? |
|
Please merge this, which was rebased onto the latest master. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #215 and #237