Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in log message #108

Open
PanderMusubi opened this issue Jan 25, 2021 · 3 comments
Open

Typo in log message #108

PanderMusubi opened this issue Jan 25, 2021 · 3 comments

Comments

@PanderMusubi
Copy link

Sorry to post this here. No way of reaching the user @Consti10 directly that made a fork that probably will make a merge request (looking forward to that).

There is a typo in the error log message Consti10@4eb76a6#diff-3feb97e9fa6f4d8dedd57d1db1f6ce44c27a4c01ac5b4e2ba3ce1368645a29beR1436

@Consti10
Copy link

Thanks.
I can make a mrege request, however, note that according to OpenHD/OpenHD#406
Sliced encoding rather increases latency than decreasing it, making it useless for our use case.

@PanderMusubi
Copy link
Author

Well, only if you think it is a useful addition. I'm not the maintainer here, just a power user that was looking into all the available branches for improvements. Then I saw this #100 . So a PR might be a MR there.

@Consti10
Copy link

Yes, I am still waiting for an answer from the rpi foundation, maybe I am missing a parameter. I don't see any other use case for sliced encoding than to reduce latency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants