Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Safe mode - recovery options #29

Closed
Gnuxie opened this issue Oct 1, 2024 · 2 comments
Closed

[Task] Safe mode - recovery options #29

Gnuxie opened this issue Oct 1, 2024 · 2 comments

Comments

@Gnuxie
Copy link
Member

Gnuxie commented Oct 1, 2024 •
edited
Loading

Main story: #1

Description

When Draupnir enters safe mode from a recoverable error, the recovery options should be shown in the status message that gets sent when safe mode first starts.

Acceptance Criteria

  • It is obvious which part of the account data based config has failed (protected rooms, watched lists, or enabled protections).
  • The config is pretty printed and values that don't match the schema are highlighted (in red or with an emoji or something)
  • It is clear in the recovery options how they will manipulate the config in relation to the pretty printed version.
  • Verbose details/error messages are hidden behind <details>.
  • When a recovery option is used, the manipulated config is pretty printed again to visually confirm all values are valid (no red/highlighted fields).

PRs
This was referenced Oct 1, 2024
Merged
Open
@Gnuxie Gnuxie changed the title [Task] Safe mode, recovery options [Task] Safe mode - recovery options Oct 2, 2024
This was referenced Oct 3, 2024
Closed
Merged
Merged
Gnuxie added a commit to the-draupnir-project/Draupnir that referenced this issue Oct 7, 2024
@Gnuxie
Make recovery UX clearer. (#601)
3f103cc 
First, we make it clear how to use the recovery options in the safe mode status command:

![Screenshot_20241007_100220](https://github.com/user-attachments/assets/07f49233-6bb1-4320-80c5-ac3aa22c1ef9)


Then a recovery option is used, we show the status of the persistent config again to reinforce to the moderator that the recovery option changed something and fixed it:

![Screenshot_20241007_102045](https://github.com/user-attachments/assets/58156a56-fe17-49e1-a93a-2591dd80aaef)

the-draupnir-project/planning#29


* Tell people how to use recovery options in safe mode status.

* Display persistent config status when a recovery option is used.
@Gnuxie
Copy link
Member Author

Gnuxie commented Oct 7, 2024

See PRs for more screenshots

Screenshot_20241007_100220

Screenshot_20241007_102045

@Gnuxie
Copy link
Member Author

Gnuxie commented Oct 7, 2024

Acceptance criteria has been met, the messages seem a little bit noisy though, maybe some extra line breaks or something would go a long way?

@Gnuxie Gnuxie closed this as completed Oct 7, 2024
@Gnuxie Gnuxie mentioned this issue Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Draupnir planning
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Gnuxie