Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Infinity max hops improperly working #72

Closed
tomek7667 opened this issue Aug 3, 2023 · 3 comments · Fixed by #77
Closed

Bug: Infinity max hops improperly working #72

tomek7667 opened this issue Aug 3, 2023 · 3 comments · Fixed by #77
Labels
bug Something isn't working

Comments

@tomek7667
Copy link 

            /* --> (optional) minimum hops for a variable length relationship */
            minHops: 1,
            /* --> (optional) maximum hops for a variable length relationship. The value Infinity can be used for no limit on the max hops */
            maxHops: 1,

The comment stating that value Infinity will be no limit for the recursion is not accurate. When entered 9999999 working perfectly fine, when entered Infinity works like for a 1 hop.
@tomek7667 tomek7667 changed the title Infinity max hops improperly working Bug: Infinity max hops improperly working Aug 3, 2023
@themetalfleece
Copy link
Owner

Hello, using Infinity generates a [*] relationship which matches 1 or more iterations.
So, is [*] used in the generated cypher but doesn't work as expected?

@tomek7667
Copy link
Author

I see, I think that I misunderstood the feature, sorry for the trouble

@themetalfleece
Copy link
Owner

No worries. In the meantime I found out a bug when only minHops is passed, I'll create a fix soon.

@themetalfleece themetalfleece added the bug Something isn't working label Aug 10, 2023
@themetalfleece themetalfleece mentioned this issue Sep 3, 2023
Merged
themetalfleece added a commit that referenced this issue Sep 3, 2023
@themetalfleece
Fix minHops & maxHops not generating correct cypher (#77)
805ce00 
fixes #72 

- Add `QueryBuilder.getVariableLengthRelationshipString` which returns
the correct inner string.
- Use it in `QueryBuilder.getRelationshipStatement`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix minHops & maxHops not generating correct cypher themetalfleece/neogma
2 participants
@themetalfleece @tomek7667