Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config for prs #20

Closed
paribaker opened this issue Oct 30, 2024 · 2 comments
Closed

Move config for prs #20

paribaker opened this issue Oct 30, 2024 · 2 comments

Comments

@paribaker
Copy link
Contributor

tn gh-all-prs relies on a config file to be present in the directory where the CLI is, so if you have it in root it looks for .config IMO this should be a config inside of a directory e.g .tncli/.config to avoid any clashes with any other files in the root.

@whusterj
Copy link
Member

Ah, my bad! .config should definitely be global. I meant for it to live in ~/.tn/config. That's how the AWS CLI does it.

Separately, I'm thinking we need to come up with some way to write reliable tests that can catch issues like this.

@whusterj
Copy link
Member

whusterj commented Nov 9, 2024

I'll handle this as part of #14

@whusterj whusterj closed this as completed Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants