Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should lock files be included in a bootstrapper/boilerplate repo like this one? #379

Open
oudeismetis opened this issue Jan 23, 2025 · 2 comments
Labels
question Further information is requested

Comments

@oudeismetis
Copy link
Contributor

In the past we had decided that lock file should NOT be committed directly to this repo and thus force devs who are bootstrapping a new project to generate them when they get started.

Let's discuss here this approach and make a decision on where we stand on it. Currently the backend does NOT have a lock file committed, but the FE does as of mid-2024.

@oudeismetis oudeismetis added the question Further information is requested label Jan 23, 2025
@oudeismetis
Copy link
Contributor Author

I did a quick look of other boilerplates on github and it seems to be a mixed bag. Some include it, some don't.

@oudeismetis
Copy link
Contributor Author

I think if we include it, a lot of projects will get bootstrapped where that lock file might not get updated for a while.
I could see a number of possible issues/risks with this:

  • Could things work day one, but then fail the second a new lock file is generated?
  • If we start getting more outside contributions to this project, could someone sneak a nefarious library in via the lock file? I think it's unlikely anyone would code review changes to those files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant