New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spaces incorrectly striped from Javascript strings #45

Open

chrisspen opened this issue Aug 22, 2024 · 0 comments

chrisspen commented Aug 22, 2024

JSMin does not appear to correctly support interpolated Javascript strings, and as a result breaks Javascript by removing spaces from strings.

Steps to reproduce:

>>> import jsmin
>>> jsmin.jsmin("count_el.text(`${data['totalDocuments']} results for ${text}`);")
"count_el.text(`${data['totalDocuments']}results for ${text}`);"

Expected result:

"count_el.text(`${data['totalDocuments']} results for ${text}`);"

Notice it incorrectly removed the space after the "}" before "results".

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment