Refactor job error handling #7291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7291 +/- ##
==========================================
+ Coverage 80.06% 82.14% +2.07%
==========================================
Files 190 217 +27
Lines 37181 38867 +1686
Branches 9450 10024 +574
==========================================
+ Hits 29770 31927 +2157
+ Misses 2997 2961 -36
+ Partials 4414 3979 -435 ☔ View full report in Codecov by Sentry. |
fabriziomello
force-pushed
the
refactor_job_error_handling
branch
4 times, most recently
from
b90c8d7 to
d2b2aac
Compare
fabriziomello
added
bgw
fabriziomello
force-pushed
the
refactor_job_error_handling
branch
from
d2b2aac to
e9dd7d7
Compare
akuzm
reviewed
Sep 26, 2024
akuzm
approved these changes
Sep 26, 2024
fabriziomello
force-pushed
the
refactor_job_error_handling
branch
from
e9dd7d7 to
8d9c367
Compare
fabriziomello
force-pushed
the
refactor_job_error_handling
branch
from
8d9c367 to
3bdbf32
Compare
Reorganized a bit the code to also record more failures in `bgw_job_stat_history` table. Also improved a bit the code coverage and added regression tests for `failed do start job` case.
fabriziomello
force-pushed
the
refactor_job_error_handling
branch
from
3bdbf32 to
e0310f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganized a bit the code to also record more failures in
bgw_job_stat_historytable.Also improved a bit the code coverage and added regression tests for
failed do start jobcase.Disable-check: force-changelog-file