Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Actor Communications #25

Open
bbengfort opened this issue Dec 18, 2015 · 2 comments
Open

Clean up Actor Communications #25

bbengfort opened this issue Dec 18, 2015 · 2 comments

Comments

@bbengfort
Copy link
Member

We quickly jammed in the color based messaging patterns for actor communications; we should clean that up and ship it as version 1 of our simulation.

@bbengfort
Copy link
Member Author

Some quick clean up tasks:

  • Change "DefaultsConfiguration" to "ClusterConfiguration
  • Put comms actors into their own package
  • Switch the if/elif handling to a jump table in the color actors
  • Move the comms manager to the comms package
  • See if we can't revamp the comms/base split in the actors package
  • Eliminate info statements for debugging by changing them to debug statements.

@bbengfort
Copy link
Member Author

  • Remove duplication between ActorManager and CommunicationsActorManager code.
  • Clean up the add_message method in gvas.utils.graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant