Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event actions not checked before sending #6

Open
lsloan opened this issue Sep 13, 2023 · 0 comments
Open

event actions not checked before sending #6

lsloan opened this issue Sep 13, 2023 · 0 comments
Assignees
@lsloan
Labels
bug Something isn't working

Comments

@lsloan
Copy link
Member

lsloan commented Sep 13, 2023

Problem

When an event is constructed without setting an action, caliper-php will allow it to be sent. Technically, it's an invalid event.

Solution

Raise an error if an event doesn't have an action set.

Considerations

Should the checking occur as the event is serialized to JSON or just before it is sent?
@lsloan lsloan added the bug Something isn't working label Sep 13, 2023
@lsloan lsloan self-assigned this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lsloan lsloan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lsloan