Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue message extraction detects dynamic key using dashed props #131

Closed
gu-stav opened this issue Dec 2, 2024 · 0 comments · Fixed by #136
Closed

Vue message extraction detects dynamic key using dashed props #131

gu-stav opened this issue Dec 2, 2024 · 0 comments · Fixed by #136
Assignees

Comments

@gu-stav
Copy link
Contributor

gu-stav commented Dec 2, 2024

When using the T component in Vue, the following SFC code fails, when running tolgee extract check:

<template>
  <T
    key-name="app.cycles.assessment.modified_by"
    default-value="Last modified {date}, by {user}"
    :params="{
      date: ''
    }"
  >
    ...
  </T>
</template>

However it passes when using camelCase props:

<template>
  <T
    keyName="app.cycles.assessment.modified_by"
    defaultValue="Last modified {date}, by {user}"
    :params="{
      date: ''
    }"
  >
    ...
  </T>
</template>

I know the latter has been documented, but some eslint rules nudge developers into using hyphenated props.

@JanCizmar JanCizmar transferred this issue from tolgee/tolgee-js Dec 2, 2024
@stepan662 stepan662 linked a pull request Dec 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants