Mappings not overwritten in summary window

[SammysHP]

Since 3d9cace, fugitive no longer overwrites previous mappings in the :Git summary window. For example, pressing <CR> does not open the file under the cursor anymore, but calls the normal mapping (:map <CR> <Plug>(wildfire-fuel) in my case).

[tpope]

The net effect of that PR was to define the maps earlier, before BufReadPost rather than after. So I'd wager the problem isn't "not overwriting", it's "being overwritten". Check :verbose map <CR> for a clue as to when/where that map is created.

[SammysHP]

Just as expected:

   <CR>          <Plug>(wildfire-fuel)
        Last set from ~/***/wildfire.vim/plugin/wildfire.vim line 59

https://github.com/gcmt/wildfire.vim/blob/dfcf48aad2e80c63272df67a1b81e37cbc443412/plugin/wildfire.vim#L59

In my opinion fugitive should have higher precedence in its own "special" buffers.

[tpope]

That's the entire output? I would expect to see 2 maps, a global one and a buffer local one. What's the output of :verbose map <buffer> <CR>?

[SammysHP]

Dumb me… ran it from the wrong window. Output of :verbose map <CR>, now from the fugitive summary window:

n  <CR>        *@<CR>
        Last set from ~/***/wildfire.vim/plugin/wildfire.vim line 70
   <CR>          <Plug>(wildfire-fuel)
        Last set from ~/***/wildfire.vim/plugin/wildfire.vim line 59

:verb map <buffer> <CR>:

n  <CR>        *@<CR>R>
        Last set from ~/***/wildfire.vim/plugin/wildfire.vim line 70

Likely the culprit:

https://github.com/gcmt/wildfire.vim/blob/dfcf48aad2e80c63272df67a1b81e37cbc443412/plugin/wildfire.vim#L75-L76

[tpope]

So wildfire.vim, in an attempt to disable itself, is overwriting our <CR> map by mapping <CR> to <CR>. This is a bug, and not one I'm inclined to work around in Fugitive. Possibly you could work around it yourself by setting g:wildfire_fuel_map to a dummy map, and mapping <CR> yourself.