Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyrics gets overwritten into another/previously saved file, causing data loss #181

Open
MemoryDump26 opened this issue Jan 17, 2025 · 2 comments

Comments

@MemoryDump26
Copy link

MemoryDump26 commented Jan 17, 2025

System info

  • Arch Linux
  • lrcget 0.9.1 - 0.9.2 (AppImage)

Reproduce

  1. Have two tracks with synced lyric.
  2. Keep editing and saving them, one after another. "Sync line" must be used at some point (and maybe "Replay line", too).
  3. At some point, one file will be overwritten by the other one.

Other

This doesn't seem to happen with handwritten timestamps, for some reason. Everything is captured in the attached video.

Unrelated: I'm just a beginner when it comes to editing lyric, but I've been enjoying lrclib a lot, and would love to see the community around it grows. Even though this issue has unfortunately caused me to lose several hours of work @@, I'm still very thankful that this project exist, and I wish it will get even better in the future.

lrcgetOverwrite.mp4
@tranxuanthang
Copy link
Owner

I think I found the culprit. There is some leftover code from the modal refactoring in v0.9.0, which is causing all sorts of issues:

<Teleport to="body">
<EditLyrics v-if="editingTrack" :is-show="!!editingTrack" />
</Teleport>

For example, when the lyrics editing feature is used by clicking the "Edit Lyrics" button, it creates an additional (invisibly mounted) "Edit Lyrics" modal. This hidden modal also intercepts hotkeys like Alt+X and Ctrl+S, causing many unexpected behaviors.

This bug is quite serious, and I’m truly sorry for the loss of your work. I’ll release a new update as soon as possible!

@tranxuanthang
Copy link
Owner

Hey, check out v0.9.3 here:

https://github.com/tranxuanthang/lrcget/releases/tag/0.9.3

Hopefully the issue is fixed now. I've tested some and haven't been able to reproduce the issue anymore, but I'm not 100% sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants