Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poap feedback #196

Open
16 of 29 tasks
JustinDrake opened this issue Sep 21, 2022 · 1 comment
Open
16 of 29 tasks

poap feedback #196

JustinDrake opened this issue Sep 21, 2022 · 1 comment

Comments

@JustinDrake
Copy link

JustinDrake commented Sep 21, 2022

  • 1559 -> 1,559
  • wrong width (screenshot 1)
  • POAP icon collides with claims count (screenshot 2)
  • incorrectly styled scroll bar (needs to be the same as burn leaderboard) (screenshot 3)
  • scroll bar collides with content (e.g. collides with monkeys)
  • use roboto for addresses
  • image and text misaligned (screenshot 4)
  • logged in as "@ultrasoundmoney" but doesn't show "not eligible"
  • too many rows shown in "1559 eligible handles" -> maybe reduce to just 6?
  • the claims counter looks too empty without "latest claimers"
  • tooltips for Twitter profile images are missing
  • the monkeys are too small -> suggest making them the same size as the twitter profile pics
  • authenticating with Twitter brings you to #discord
  • the new /fam page feels too empty/unready/unpolished -> suggest focusing and only incrementally adding the three POAP widgets (without changing "fam count" and "wear the bat signal")
  • the POAP animation on a continuous is a bit obnoxious -> suggest more subtle animations, e.g. on hover or when interacting with the POAP page (e.g. scrolling eligible handles, entering Twitter handle, entering wallet address)
  • inconsistent width with Discord widget (screenshot 6)
  • sending to justin.eth gives "error" with no further details (screenshot 7)
  • "bragging rights for the 1559 pre-merge fam" -> "only 1,559" (see Figma)
  • missing skeleton when loading (screenshot 8)
  • image loading is not gracefully degrading (suggest reusing logic, e.g. from burn leaderboard) (screenshot 9)
  • missing top spacing when clicking #poap section (screenshot 10)
  • "claimed by @drakefjustin!" is a bit strange when combined with "YOUR WALLET ADDRESS" (screenshot 11)
  • the monkeys don't smoothly rotate (screenshot 12) -> a good-enough solution may be to cycle through 🙈🙉🙊 in a round-robin fashion?
  • various items should be non-selectable (see green highlights in screenshot 13)
  • incorrect hover cursor on nerd emoji (should pointer)
  • images sometimes disappear for a bit then reload
  • some images (e.g. that of stonecoldpat0) are not loading
  • accordeons default open
  • "not enough fam followers to claim" -> "not eligible for POAP"

screenshot 1

Screenshot 2022-09-21 at 20 11 44

screenshot 2

Screenshot 2022-09-21 at 20 12 41

screenshot 3

Screenshot 2022-09-21 at 20 13 26

screenshot 4

Screenshot 2022-09-21 at 20 15 52

screenshot 5

Screenshot 2022-09-21 at 20 18 49

screenshot 6

Screenshot 2022-09-21 at 20 26 51

screenshot 7

Screenshot 2022-09-21 at 20 31 04

screenshot 8

Screenshot 2022-09-21 at 20 32 41

screenshot 9

Screenshot 2022-09-21 at 20 35 03

screenshot 10

Screenshot 2022-09-21 at 20 37 18

screenshot 11

Screenshot 2022-09-22 at 09 52 53

screenshot 12

Screenshot 2022-09-22 at 09 54 01

screenshot 13

Screenshot 2022-09-22 at 20 18 49

@alextes
Copy link
Member

alextes commented Sep 21, 2022

With our styling the scrollbar becomes invisible.
I'd say no scrollbar or keep the native one.
Also, I think the scroll bar should be on top of the content. It looks quite good on my screen. Uglier if you mouse over and grab it, perhaps we can just style that aspect instead?

Tooltips is tricky, that component is messy, a bit heavy, and we have 1559 rows here. I could try, but I'd leave it as an upgrade.

Two column styling is still to be done, so I'm ignoring the two width comments until after.

Sounds like "not eligible" or "claimed" but if it's neither we should check. I noticed claim counter got to two, that's why. But check the site, if you see neither check the console and let me know the error.

I think we shouldn't lose too much momentum here. Latest claimers requires a whole new endpoint, not that hard, but again, why not just upgrade the widget after it's live if we feel its more valuable than everything else we want to do (heads-up, I don't think it is 😅 )

Tell me more about the suggested alternative incremental approach? Although really I'd like to get you on-board with releasing this page and dropping the POAP asap.

Great feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants