Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Update get wallet Atom Hook in connectwallet.ts #21

Closed
adrianvrj opened this issue Jan 22, 2025 · 14 comments · Fixed by #26
Closed

[feat] Update get wallet Atom Hook in connectwallet.ts #21

adrianvrj opened this issue Jan 22, 2025 · 14 comments · Fixed by #26
Assignees
Labels
easy enhancement New feature or request ODBoost

Comments

@adrianvrj
Copy link
Member

Description

Refactor the walletStarknetkitLatestAtom in connectwallet.ts to use atomWithStorage for persistent storage instead of atomWithReset. This will ensure that the wallet information is stored and retrieved correctly across app sessions.

Requirements

  1. Update Atom Implementation:

• Replace the current atomWithReset implementation with atomWithStorage.

• Update the walletStarknetkitLatestAtom definition to store the value in persistent storage.

• New implementation should look like this:

export const walletStarknetkitLatestAtom = atomWithStorage<undefined | null | StarknetWindowObject>
('walletStarknetkitLatest', undefined);
  1. Regression Testing:

• Run regression tests across the entire application to ensure that this change does not break any existing functionality.

Acceptance Criteria

• The walletStarknetkitLatestAtom is updated to use atomWithStorage correctly.

• Regression tests pass successfully across all parts of the app, with no issues related to this change.

• Persistent wallet data works as expected, preserving the state across sessions.

Important

Each commit should include the number of the issue to keep track of the issues, ex:

#[your-issue-number] - issue description

@adrianvrj adrianvrj added enhancement New feature or request ODBoost easy labels Jan 22, 2025
@ooochoche
Copy link

Gm, can I work on this part of the project. I am proficient in TypeScript

@OthmanImam
Copy link

I'm Usman Adamu, a developer.
I will love to beautifully carryout this task.

@raizo07
Copy link

raizo07 commented Jan 22, 2025

May I try my hand at this?

I'm a Software dev with over four years experience

ETA: 5 hours

@Benjtalkshow
Copy link

I am a Full Stack Developer specializing in Next.js, TypeScript, Node.js, Cairo and Rust . With over 50 contributions across projects in the OnlyDust ecosystem, I’ve developed strong proficiency in delivering high-quality solutions and resolving complex issues within tight deadlines. My experience spans frontend, backend, smart contracts, and the optimization and maintenance of scalable codebases.
I can handle this task. Kindly assign.

@Michaelkingsdev
Copy link

Could I be assigned to this?

@Wendyalbert
Copy link

Could I take on this issue?

@Emmanex01
Copy link

Could I take a shot at this?
I'm Emmanuel Tochukwu, frontend and smart contract developer. I have experience building projects using JavaScript, Cairo, Tailwindcss, Typescript and Nextjs. If given this issue, I will deliver as soon as possible.

@josephchimebuka
Copy link

Hello, I am Joseph Chimebuka and I am an active software developer and a Diamond contributor on Onlydust I can handle this task can you please assign. I will create a PR in 48hrs

@pheobeayo
Copy link

Let me handle this issue!

@caxtonacollins
Copy link

Can I try solving this issue?

@ShantelPeters
Copy link

Could I try solving this?

@CollinsC1O
Copy link

May I be assigned to this?

@espaciofuturoio
Copy link
Contributor

May I try my hand at this?

@aidenwong812
Copy link

Let me handle this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy enhancement New feature or request ODBoost
Projects
None yet
Development

Successfully merging a pull request may close this issue.