-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser support #5
Comments
Currently working on a browser extension to detect media. |
I've never written browser extensions nor do I know how the extension gathers its metadata and whether it needs access to website data to function. But if the browser extension requires granting access to site data on every site, starting with no such permissions and granting access only to sites that you need to pass metadata on from to the app would be ideal. I've seen behaviour like this on some Firefox extensions, where you enable features for specific sites, and only then it asks you to give permissions to access that site's data. I generally prefer extensions that limit their permissions to what's strictly necessary. Of course there are exemptions, e.g. a password manager or an ad blocker where full access is unavoidable by design and usability. Thanks. |
The extension as I've written it so far is open-source: https://github.com/ungive/media-control-extension Anyone who installs it would be able to verify it does nothing malicious. I'm not sure anymore, but I think I had to use |
How to install that? |
The extension as it's written now isn't helping with showing a Discord status at the moment, you can only observe and control media playback of your browser tabs. I also haven't made any release so far, you'd have to build it from source. I could do that if you want to try it out.
It's detected from the browser, but Music Presence whitelists media players. With browsers specifically it's impossible to tell the exact website the media is coming from, so Music Presence can't tell if it's from e.g. YouTube or another site that you might very much not want to see in your status. Enabling the browser as a whole is not really desirable for most users, so a browser extension is the way to go. I will continue working on this soon. |
Why not add feature to detect browsers as well and if users do not want, just give them option in settings menu to disable ? |
The initial approach for me was to whitelist every player explicitly, so that users are encouraged to report when a media player does not work and I can collect media player identifiers to better support them, see #4. That excluded allowing for just any media player to be shown in the status directly. I also didn't want to view a browser as a "media player" and whitelist it, mainly because it's really not a media player, but also since in many cases a user will at some point consume some other media they simply don't want to share in their status and they might have forgotten to turn the browser off again. In effect it's a design choice. At least I could see myself stepping on my toes numerous times when allowing browser media to be shown in my status without finer grained control. |
To add to that, a browser from Music Presence's point of view is not a "media player" but more like an "application environment". You run web applications in a browser and by enabling a whole browser to be shown in your status you enable any and all of those applications you run in that browser. If you move that analogy to your operating system instead of your browser, that would be like enabling all apps on your computer without getting a choice which one you want to enable. Either all of them or none. From a design perspective I don't want that. The user should be able to choose which web application (or website) to share and which not. |
Overview
It would be great if Music Presence could support browsers. This is not trivial to implement though, as browsers can usually play way more than just music. Most notably, videos a user is playing might interfere with the original intention behind Music Presence: The user doesn't want to show which video they are watching, but only which music they are listening to. For this reason media from browser's must be filtered in some way.
Ideas
A browser extension is likely the way to go here.
Any input and ideas are welcome!
The text was updated successfully, but these errors were encountered: