Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] sang session id, if intentionally corrupted, leads to infinite recursion #112

Open
rtshkmr opened this issue Sep 24, 2024 · 0 comments
Assignees
Labels
lift.medium expected lift for it is medium. e.g. some unknowns expected priority.low type.bug Something isn't working

Comments

@rtshkmr
Copy link
Member

rtshkmr commented Sep 24, 2024

replication steps:

  1. load page normally at /explore
  2. refresh and see no issues
  3. inspect to see stored session id (for sanghsession)
  4. replace the id to use illegal char (non-hex) e.g. z can be used as the first char
  5. observe that the reinit of session is attempted infinitely and the VM's space will run out.

while this is a catastrophic bug, it can only happen now if a user manually modifies the id via devtools, so this bug is unlikely to present itself easily. Hence the lift and priority tags for this.

@rtshkmr rtshkmr added type.bug Something isn't working priority.low lift.medium expected lift for it is medium. e.g. some unknowns expected labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lift.medium expected lift for it is medium. e.g. some unknowns expected priority.low type.bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants