Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the version of glob #389

Open
ematipico opened this issue Feb 2, 2024 · 4 comments · May be fixed by #390
Open

Upgrade the version of glob #389

ematipico opened this issue Feb 2, 2024 · 4 comments · May be fixed by #390
Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed

Comments

@ematipico
Copy link

ematipico commented Feb 2, 2024 •
edited
Loading

The current version of glob uses an outdated - very outdated - version of minimatch. That version of micromatch is CommonJS only and it breaks production code when deployed to serverless function.

For more reading: withastro/astro#9935
@JasonTame
Copy link

Minor correction - it's minimatch that is outdated with the current version of glob, not micromatch

@styfle styfle linked a pull request Feb 2, 2024 that will close this issue
Draft
@styfle
Copy link
Member

styfle commented Feb 2, 2024

I started a PR here but looks like Windows is failing since glob has changed from backslash to forward slash

If someone who has windows wants to fix it, feel free.

@styfle styfle added the dependencies Pull requests that update a dependency file label Feb 2, 2024
@anviksuteiriy
Copy link

anviksuteiriy commented Sep 11, 2024 •
edited
Loading

Hey, any update on this since there is a warning of memory leak reported for this version glob --> inflight ?

Screenshot from 2024-09-11 12-17-34

@styfle styfle added the help wanted Extra attention is needed label Sep 13, 2024
@benmccann
Copy link
Contributor

It might be a good opportunity to switch glob libraries

https://npmgraph.js.org/?q=glob - 26 dependencies
https://npmgraph.js.org/?q=tinyglobby - 2 dependencies

@styfle styfle mentioned this issue Dec 9, 2024
Merged
@danielroe danielroe mentioned this issue Jan 13, 2025
Closed
@danielroe danielroe mentioned this issue Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): bump [email protected] and [email protected] vercel/nft
5 participants
@styfle @benmccann @ematipico @JasonTame @anviksuteiriy