Drop specific permission amounts in pure functions's preconditions #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jcp19
commented
Dec 2, 2024
verification/dependencies/github.com/google/gopacket/layertype.gobra
Outdated
Show resolved
Hide resolved
verification/dependencies/github.com/google/gopacket/layertype.gobra
Outdated
Show resolved
Hide resolved
jcp19
commented
Dec 2, 2024
|
There are severe performance implications by this PR at the moment. I expect this to be fixed by the time viperproject/silicon#877 is merged |
|
Requires reverting PR viperproject/gobra#813 after all issues with the new semantics of permissions in function preconditions are fixed |
* backup * cleanup * Update pkg/slayers/scion.go * Update pkg/slayers/scion_spec.gobra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In anticipation for the PR viperproject/silicon#877, I'm opening this PR that drops all perm amounts in function preconditions.
The goal is to access if any of our pure functions depends on aliasing information. Once the PR is merged in silicon, we should clean-up the source program even more, by dropping all_from accessibility predicates in pure function preconditions / unfoldings.It might make sense to open a PR in Gobra to report any use of concrete perm amounts in pure functions later on.
This PR also does a fair deal to stabilize proof obligations. I looked at ill-formed triggers (at the Viper level) and adapted the code (mostly, by introducing function
AssertSliceOverlap) to generate proper triggers.TODO: