Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop is not working for songs playing outside of standard playlist #2223

Open
przunk opened this issue Aug 24, 2023 · 5 comments
Open

Loop is not working for songs playing outside of standard playlist #2223

przunk opened this issue Aug 24, 2023 · 5 comments

Comments

@przunk
Copy link

przunk commented Aug 24, 2023

When playing the song from "Playlist" view, everything seems to be working fine.
In "Browser" view, when loading local playlist or local file, looping the song don't work. The song is played once, and then there is just a silence - progressbar is still indicating the progress of the song, but no sound can be heard.

Steps for reproduction:

  • Open ZX Tune
  • Switch to "Browser" view
  • Browse the local filesystem and select a file to play (tested on Pokey "sap" files)
  • In "Main" view, select button for looping the song

Result:
When the song ends, it doesn't repeat as expected. Progressbar is running forward (probably taking CPU time) but no sound is played.

Expected:
The sound will loop indefinately.

This issue doesn't apply for "Playlist" view, when the song is added to standard playlist and played.

I am positive, that this issue didn't apply for older versions (few months back)

App. version r5050-thin

@przunk
Copy link
Author

przunk commented Aug 24, 2023

Observations after some more tests:
This issue seems to be affecting only certain types of songs. In particular, some files which define goto 00 segment of the song at the end.
Tested on these files:

@vitamin-caig
Copy link
Owner

vitamin-caig commented Aug 25, 2023

If track doesn't have sound produced after playback for specified duration, it will be silence at looping. This usually actual for emulated formats.
Yep, this is actual for Back_to_the_Scene.sap

@vitamin-caig
Copy link
Owner

And it doesn't matter whether track was played from playlist or browser.

@przunk
Copy link
Author

przunk commented Aug 27, 2023

Is this expected (valid) behaviour? Many songs have 1-pattern long pause at the end, which in this case effectively disables looping capabilities for them. In my opinion, loop is a loop - the song should jump to the beginning when reaching the end. I understand particular characteristics of chip music - some songs should not loop to the beginning but to the defined region.

@vitamin-caig
Copy link
Owner

Playback should be looped to intended position (or at the beginning if it's not specified).
As for specified modules, used playback library doesn't support forced looping (I guess, it just obeys internal loop control commands).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants