Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viur create calls clean_base.py with application-name-parameter even if not set #153

Open
bb-mausbrand opened this issue May 16, 2024 · 2 comments · May be fixed by #176
Open

viur create calls clean_base.py with application-name-parameter even if not set #153

bb-mausbrand opened this issue May 16, 2024 · 2 comments · May be fixed by #176
Labels
bug Something isn't working viur-meeting Issues to discuss in the next ViUR meeting
Milestone

Comments

@bb-mausbrand
Copy link

Running viur create [project-name] runs clean_base.py with parameter -A [project-name] even if it istn't properly configured. This leads i.e. to the application name being "{{app_id}}"

@bb-mausbrand
Copy link
Author

it should have changed two lines in deploy/main.py:
34: conf["viur.validApplicationIDs"] = ["{{app_id}}"]
88: conf["admin.name"] = "{{app_id}}"

@phorward
Copy link
Member

Should be resolved together with #165.

@phorward phorward added bug Something isn't working viur-meeting Issues to discuss in the next ViUR meeting labels Aug 29, 2024
@Grashalmbeisser Grashalmbeisser linked a pull request Oct 9, 2024 that will close this issue
@Grashalmbeisser Grashalmbeisser added this to the v2.1.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working viur-meeting Issues to discuss in the next ViUR meeting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants