Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Evaluate multiple ngram speculations in speculative decoding #6785

Closed
chenglu66 opened this issue Jul 25, 2024 · 3 comments
Closed

Comments

@chenglu66
Copy link

🚀 The feature, motivation and pitch

During the ngram-spec-decode stage, I've always had a question: In RAG, there isn't just one document relevant to the answer; why don't we first let the large model generate 3 tokens, and then take all possible results in the N-gram?

In simpler terms, imagine you're looking for an object in several rooms but can only carry three things at once. You might want to pick up some important items now so you won't forget them when carrying more stuff later. This way, you make sure your search is efficient and effective.

Alternatives

No response

Additional context

No response

@cadedaniel
Copy link
Collaborator

You can do this, and in fact this is something we want to do in vLLM. The primary tradeoff is that verification of additional speculative tokens costs FLOPs, so if you don't pick carefully you can end up hurting overall performance (especially as number of concurrent requests grows). See #4565 for more details here.

In terms of implementing this in vLLM, we need #3960 first.

@cadedaniel cadedaniel changed the title [Feature]: ngram-spec-decode [Feature]: Evaluate multiple ngram speculations in speculative decoding Jul 25, 2024
Copy link

This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this issue should remain open. Thank you!

@github-actions github-actions bot added the stale label Oct 24, 2024
Copy link

This issue has been automatically closed due to inactivity. Please feel free to reopen if you feel it is still relevant. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants