Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Contribute T5 model to vLLM #8036

Closed
1 task done
shivance opened this issue Aug 30, 2024 · 3 comments · May be fixed by #3117
Closed
1 task done

[Feature]: Contribute T5 model to vLLM #8036

shivance opened this issue Aug 30, 2024 · 3 comments · May be fixed by #3117

Comments

@shivance
Copy link

🚀 The feature, motivation and pitch

Hi vLLM team,
As you already know, T5 is a perfect model and as mentioned in #7366, the project intends to add support for T5. I want to help the cause and contribute T5 to the project.

As this is my first contribution to vLLM project I am quite pumped up as well as eager to learn from you all.

Alternatives

No response

Additional context

No response

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@robertgshaw2-redhat
Copy link
Collaborator

robertgshaw2-redhat commented Aug 30, 2024

@shivance thanks for your interest!

See: #7366 for a detailed discussion of enc-dec support. We would definitely welcome help on T5. For T5, the key is that we need an attention implementation with the custom bias

Copy link

This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this issue should remain open. Thank you!

@github-actions github-actions bot added the stale label Nov 29, 2024
Copy link

This issue has been automatically closed due to inactivity. Please feel free to reopen if you feel it is still relevant. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants